Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concept/requires keywords are not highlighted #5546

Closed
michelleangela opened this issue May 21, 2020 · 3 comments
Closed

concept/requires keywords are not highlighted #5546

michelleangela opened this issue May 21, 2020 · 3 comments
Labels
Feature: Colorization Language Service Visual Studio Code Caused by (or depends on changes from) VS Code
Milestone

Comments

@michelleangela
Copy link
Contributor

I have 1.45.1 VSC and 0.28.1 C++ extension and concept/requires keywords are not highlighted even though VSC clearly knows(they're suggested) that they're C++ keywords.

Originally posted by @OleksandrKvl in #4195 (comment)

@michelleangela
Copy link
Contributor Author

michelleangela commented May 21, 2020

@Colengc does the extension support _concepts and requires_ keywords for enhanced colorization? Or is this a feature request?

@Colengms
Copy link
Collaborator

'concept' and 'requires' are syntactic tokens. Semantic parsing is not required to identify them. Syntactic colorization comes from VS Code and TextMate grammer. So, I believe this would be a VS Code issue.

The issue may be tracked by:

jeff-hykin/better-cpp-syntax#396

The TextMate grammer from that repo is contributed to VS Code. Often changes are available in the "Better C++ Syntax" extension before they are available in VS Code. Using the latest version of that extension, concept and requires are colorized.

@Colengms Colengms added this to the Tracking milestone May 21, 2020
@Colengms Colengms added the Visual Studio Code Caused by (or depends on changes from) VS Code label May 21, 2020
@sean-mcmanus sean-mcmanus changed the title _concept/requires_ keywords are not highlighted concept/requires keywords are not highlighted May 21, 2020
@Colengms
Copy link
Collaborator

Closing this, as we don't generally keep tracking issues open in this repo for issues with VS Code's TextMate grammar. Since this has been addressed in the Better Syntax extension, it should just seem to be a matter of time until VS Code gets an updated grammar.(?)

@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature: Colorization Language Service Visual Studio Code Caused by (or depends on changes from) VS Code
Projects
None yet
Development

No branches or pull requests

2 participants