Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

semantic tokens: use 'method' instead of 'member' #6569

Closed
aeschli opened this issue Nov 23, 2020 · 3 comments
Closed

semantic tokens: use 'method' instead of 'member' #6569

aeschli opened this issue Nov 23, 2020 · 3 comments
Assignees
@Colengms
Labels
Feature: Colorization fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Milestone
1.2.0

Comments

@aeschli
Copy link

aeschli commented Nov 23, 2020

After requests in microsoft/language-server-protocol#1087 we decided to deprecate the 'member' token type in favor of a new 'method' token type.

The 'method' token type stands for all types of member functions (also if the language calls it differently)

VSCode issue: microsoft/vscode#111172

@Colengms FYI
@Colengms Colengms self-assigned this Nov 23, 2020
@Colengms
Copy link
Collaborator

I gather this change will need to wait until VS Code 1.52 is released.

@Colengms Colengms added this to the 1.2.0 milestone Nov 23, 2020
@aeschli
Copy link
Author

aeschli commented Nov 24, 2020

Yes, you better wait until 1.52 is out (or restrict the extension to 1.52)

@Colengms Colengms mentioned this issue Dec 14, 2020
Merged
@Colengms Colengms added the fixed Check the Milestone for the release in which the fix is or will be available. label Dec 15, 2020
@sean-mcmanus
Copy link
Collaborator

Fixed with https://github.com/microsoft/vscode-cpptools/releases/tag/1.2.0-insiders2

@bobbrow bobbrow added fixed Check the Milestone for the release in which the fix is or will be available. and removed fixed Check the Milestone for the release in which the fix is or will be available. labels Jan 26, 2021
@Colengms Colengms closed this as completed Feb 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Colengms Colengms

Labels
Feature: Colorization fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
4 participants
@aeschli @bobbrow @sean-mcmanus @Colengms