Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display keybindings on different platform #765

Closed
rebornix opened this issue Dec 15, 2016 · 1 comment
Closed

Display keybindings on different platform #765

rebornix opened this issue Dec 15, 2016 · 1 comment

Comments

@rebornix
Copy link
Member

rebornix commented Dec 15, 2016

Review #702

In https://code.visualstudio.com/docs/editor/codebasics sometimes we are showing keybindings for different platforms

you can switch between them quickly by holding the Ctrl (Mac: 'Cmd') key

but sometimes we are smart enough to know that users are using Mac and we just show keys specific for Mac.

It's not a big deal but maybe we want to align them. Making it smart always.

@gregvanl
Copy link

We can use the platform specific key binding look up (command id -> keyboard shortcut) when the text is talking about a command which has a command id. When the text is mentioning a single key like cmd, we have to include both the Windows/Linux and Mac key since there is no command id to lookup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants