Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy: DevKit should not take a required dependency on .200+ SDK features #1033

Closed
timheuer opened this issue Mar 27, 2024 · 5 comments
Closed
Labels
area-nuget NuGet Package Manager triaged The issue has been triaged
Milestone

Comments

@timheuer
Copy link
Member

timheuer commented Mar 27, 2024

From vscode-csharp created by richlander: dotnet/vscode-csharp#7006

This came from a discussion of possible new features taking a dependency on feature-band SDK capabilities

Linux distros that offer .NET (as a general rule) only offer .1xx feature band SDK versions. We've put a lot of effort into making Linux distros successful with source build. Source build is .1xx only. We want people to be happy and satisfied with using the .NET that is available in RHEL, Ubuntu, and friends.

As a result, we need a policy that any DevKit features that rely on .2xx+ functionality fail gracefully when using a .1xx SDK.

@jebriede
Copy link

Is the ask to not depend on .NET SDK or to fail gracefully when the required version is not installed?

Currently, we fail gracefully if the required .NET SDK version is not installed on the user's machine, and we offer guidance on what version is required and how to install it.

@timheuer
Copy link
Member Author

The impact here in having a strong dependency is that with the new changes to certain Linux distros, the acquisition ofr a .2xx SDK will not be intuitive, nor does the SDK acquisition pack handle these any more. So it will be a manual step to get that SDK, and has potential to impact the user's machine in other ways as we've seen.

The goal would be to prevent this. If "fail gracefully" means that nobody gets NuGet commands, that feels bad.

@github-actions github-actions bot removed the needs-more-info Needing more information, waiting on OP label Apr 25, 2024
Copy link

@jebriede, the 'needs-more-info' label has been removed upon receiving further response from the original bug filer.

@richlander
Copy link
Member

@nkolev92 nkolev92 added this to the Backlog milestone May 1, 2024
@jeffkl jeffkl added the triaged The issue has been triaged label May 6, 2024
@jebriede
Copy link

Team Triage: Thanks for the feedback. We believe this will be addressed when this work is completed: #1140.

@jebriede jebriede closed this as not planned Won't fix, can't repro, duplicate, stale Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-nuget NuGet Package Manager triaged The issue has been triaged
Projects
None yet
Development

No branches or pull requests

5 participants