Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic comment prefix based on file type? #1064

Closed
dotansimha opened this issue Sep 4, 2020 · 1 comment
Closed

Dynamic comment prefix based on file type? #1064

dotansimha opened this issue Sep 4, 2020 · 1 comment
Labels
feature-request Request for new features or functionality
Milestone
2.2.1

Comments

@dotansimha
Copy link
Contributor

As I can see in the code here:
https://github.com/microsoft/vscode-eslint/blob/master/server/src/eslintServer.ts#L1666-L1680

The actions for disabling are always using // or /*, but in some cases, like with files of type .yaml, a # needs to be used instead of //.

What do you think? Is that a valid use case? If so, I can open a PR ;)
@dbaeumer
Copy link
Member

dbaeumer commented Sep 7, 2020

Actually that does make sense and someone already started to look into this for Coffeescript. So may be you can simply extend the PR https://github.com/microsoft/vscode-eslint/pull/857/files

@dbaeumer dbaeumer added the feature-request Request for new features or functionality label Sep 7, 2020
@dbaeumer dbaeumer added this to the Backlog milestone Sep 7, 2020
@dbaeumer dbaeumer modified the milestones: Backlog, 2.2.0 Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
2.2.1
Development

No branches or pull requests
2 participants
@dbaeumer @dotansimha