Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Extention uses ESLint installed as dependency of a dependency instead of a root dependency #144

Closed
sanderhouttekier opened this issue Sep 22, 2016 · 2 comments
Labels
info-needed Issue requires more information from poster

Comments

@sanderhouttekier
Copy link

sanderhouttekier commented Sep 22, 2016

The documentation tells us (currently i'm at 1.0.6 of the vscode-eslint extension)

"The extension uses the ESLint library installed in the opened workspace folder. If the folder doesn't provide one the extension looks for a global install version."

but I notice the following behavour:

ESLINT not globally installed on my pc

npm list in the project folder:

...
├─┬ eslint@3.5.0
...
├─┬ grunt-sass-lint@0.1.2
│ └─┬ sass-lint@1.9.0
│   ├─┬ eslint@2.13.1
...

package.json

...
dependencies: {
...
    "eslint": "^3.0.0",
...
}

In Visual Studio Code's internal terminal window, execute:

sander@vagrantbox $ eslint -v                                                                            
v2.13.0                                                                                                                                       
sander@vagrantbox $ ./node_modules/eslint/bin/eslint.js  -v                                              
v3.5.0                                              

this leads me to believe, the exposed eslint version prefers the dependency of a dependency over the one specified as root dependency.

@dbaeumer dbaeumer added the info-needed Issue requires more information from poster label Sep 22, 2016
@dbaeumer
Copy link
Member

No, it shouldn't. The extension is not coupled to the terminal. You can enable tracing to see what module will be resolved. Set the setting "eslint.trace.server": "messages". This should print the resolve module path in the ESLint Output panel. If it resolves the wrong one please let me know.

@dbaeumer
Copy link
Member

dbaeumer commented Nov 6, 2017

This issue has been closed because it needs more information and has not had recent activity. Thank you for your contributions.

@dbaeumer dbaeumer closed this as completed Nov 6, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants