Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previous errors aren't cleared when the config file becomes invalid #148

Open
roblourens opened this issue Sep 27, 2016 · 1 comment
Open
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@roblourens
Copy link
Member

Testing microsoft/vscode#12602

  • Have a js file with some eslint error decorations visible.
  • Edit the eslintrc.json to be invalid
  • A warning is printed to the Output, but the error decorations are still visible, even if the code is edited to address them.
  • If I reopen the editor, then the errors are gone.

It seems like all decorations should be cleared when the extension is no longer checking. Is that possible?

image

@dbaeumer
Copy link
Member

Need to think about this. The problem is that if the user types in that file you don't want to clear them.

@dbaeumer dbaeumer added this to the November 2016 milestone Oct 14, 2016
@dbaeumer dbaeumer modified the milestones: Backlog, November 2016 Feb 3, 2017
@dbaeumer dbaeumer added the bug Issue identified by VS Code Team member as probable bug label Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants