golint tool install fails due to new path

[gilcrest]

When compiling go tools, vscode is attempting to install golint using go get -u -v github.com/golang/lint/golint, however, it should be using go get golang.org/x/lint/golint

Per golang/lint a recent commit (Oct 10) enforced that clients update their path for golint.

golint:
Error: Command failed: /usr/local/bin/go get -u -v github.com/golang/lint/golint
github.com/golang/lint (download)
package github.com/golang/lint/golint: code in directory /Users/gilcrest/dev/go/src/github.com/golang/lint/golint expects import "golang.org/x/lint/golint"
github.com/golang/lint (download)
package github.com/golang/lint/golint: code in directory /Users/gilcrest/dev/go/src/github.com/golang/lint/golint expects import "golang.org/x/lint/golint"

Thanks!

[glerchundi]

@gilcrest it seems like it's solved on master so once they release a new version issue will be gone 9608da3.

[ramya-rao-a]

@glerchundi is right. The fix is in master.

You can try the latest beta version of this extension which has the fix until I release an update sometime this week

[gilcrest]

OK, thanks @ramya-rao-a ! I'm just trying to understand from a process perspective. There is an issue with the current release due to this external change. I was just wondering why this issue gets closed if the issue is not resolved in a GA release? I would think that it's helpful for others who may be experiencing the issue to be able to easily search for this until it's GA?

The first thing I did was search open issues (which is also the default search method on Github) and found no open issues involving golint path. I figured that since there wasn't an open issue, I should report it. Only at this point did I go through the steps to open a new issue...

Excuse my ignorance, but just wondering if it's commonplace to close issues when they are resolved in beta only? I also noticed several other users went through the same steps of opening issues when the problem had been already solved.

Next time I have an issue, should I search the closed issues as well as master for latest commits?

Thanks a lot for all the time and energy you put into this extension - I really appreciate all the great work you do!

[ramya-rao-a]

Hey @gilcrest,

When there is a PR which has a comment ending with something like "Fixes #" followed by the issue number, or there is a commit with the commit message following that patter, the issue gets automatically closed when the change makes it to the master branch.

This said, not all PR, commits follow this pattern and sometimes, the fix for an issue will be in master, but the issue will still be open.

Having a consistency here would mean that I have to go and re-open issues that were fixed. It doesn't sound like much, but it is at the end of the day, an overhead I can do without. Especially, because its just me managing this project.

I also tend to close a new incoming issue if the fix is already in master with a note explaining just that. This helps me in managing the influx of issues and the triaging process.

If there was already another issue, I would add the label duplicate, and then I would add the link to it as well. This is what I missed to do for the current issue that you logged. It was being tracked in #1997

Therefore, the best thing to do before logging an issue would be to look at both open and closed issues. If there is a merged PR linked to the issue, then the fix is in master.

Once I release an update, there are a couple of things I make sure I do

• Ensure the Changelog has links to every bug/feature request and PR that made it to the release
• Update each bug/feature request that the fix is now available in the latest update. I don't do this for issues marked as duplicate though.

Regardless of this, I do appreciate you logging this issue. It got quite a few upvotes that gives me an idea of how many people had the issue.

Thanks! and Happy Coding!

[gilcrest]

@ramya-rao-a - "Especially, because its just me managing this project." - that is stunning. Thank you again for all that you do for the Go community, the amazing product you're building and shepherding and for this detailed response. I am happy to look in opened and closed issues and will do so going forward!

Best,

Dan