Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply file decorators to project level #481

Closed
Tracked by #1191
beckermarc opened this issue Apr 7, 2021 · 1 comment · Fixed by #735
Closed
Tracked by #1191

Apply file decorators to project level #481

beckermarc opened this issue Apr 7, 2021 · 1 comment · Fixed by #735
Labels
enhancement New feature or request

Comments

@beckermarc
Copy link

beckermarc commented Apr 7, 2021

In the January blog post on Java in VS Code you announced support for color highlighting / file decoration in the Java Projects Explorer: https://devblogs.microsoft.com/java/java-on-visual-studio-code-update-january-2021/

Is it possible to also provide this color highlighting to the very top of the projects hierarchy, similar to how this is handled in the File Explorer?

For example here I'd also expect the nodes cds-services and cds-feature-jdbc to be highlighted in yellow:
image

I really like the Java Projects Explorer, but this is the main aspect that keeps me from using it regularly. Improving this would make refactorings in big projects much easier were you temporarily might create a lot of compilation issues across various project parts. With the current behaviour it is really hard to spot at a first glance in which project there are still issues or warnings, especially in very big projects.

Thanks a lot!

@jdneo
Copy link
Member

jdneo commented Apr 8, 2021

Thank you for the feedback @beckermarc!

Some explanation why

Currently we do not highlight the project node on purpose, because with the current implementation, some files are not listed under the project node(for example, pom.xml). If the user only modifies the pom.xml, it will add a decoration at the project node, but when user expands all the children nodes, he will find nothing is changed, that could be annoying.

Follow-up actions

While this reminds us that we need to consider display these files in the project explorer, this request also appears before: #145, #229 (comment). Once this request is implemented, then we can enable the highlighting for the project node.

@jdneo jdneo added the enhancement New feature or request label Apr 8, 2021
@jdneo jdneo changed the title Top-level color highlighting in Java Projects Explorer Apply file decorators to project level Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants