Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into webview UI toolkit for the table implementation #10219

Closed
Tyriar opened this issue Jun 1, 2022 · 6 comments
Closed

Look into webview UI toolkit for the table implementation #10219

Tyriar opened this issue Jun 1, 2022 · 6 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug variable-explorer

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 1, 2022

Testing #10170

We have a library that can be used which aims to provide a consistent experience with the rest of VS Code and it contains a table widget: https://code.visualstudio.com/blogs/2021/10/11/webview-ui-toolkit

I'm not sure of the current state but I believe it should meet accessibility requirements as well.

@sadasant sadasant added the triage-needed Issue needs to be triaged label Jun 1, 2022
@sadasant
Copy link
Contributor

sadasant commented Jun 1, 2022

Thank you, @Tyriar ! We'll follow up after we circle through the open issues during our next triage.

@greazer
Copy link
Member

greazer commented Jun 2, 2022

We can't use the webview tableview toolkit until it supports virtualization.

@sadasant
Copy link
Contributor

sadasant commented Jun 2, 2022

Here’s the virtualization issue: microsoft/vscode-webview-ui-toolkit#210

@Tyriar
Copy link
Member Author

Tyriar commented Jun 2, 2022

@greazer keep in mind accessibility is critical, also I suspect that virtualization issue will be indefinitely blocked until it gets some engineering resources.

@greazer
Copy link
Member

greazer commented Jun 3, 2022

Yes, indeed on accessibility.

@greazer greazer added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues and removed triage-needed Issue needs to be triaged labels Jun 3, 2022
@sadasant sadasant removed their assignment Jul 27, 2022
@IanMatthewHuff IanMatthewHuff removed their assignment Nov 10, 2022
@roblourens
Copy link
Member

microsoft/vscode#165445

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug variable-explorer
Projects
None yet
Development

No branches or pull requests

7 participants
@roblourens @sadasant @IanMatthewHuff @rebornix @Tyriar @greazer and others