Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting install from prompt when missing pip fails because pip is not available #10400

Closed
amunger opened this issue Jun 9, 2022 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) notebook-getting-started

Comments

@amunger
Copy link
Contributor

amunger commented Jun 9, 2022

  1. Install a python interpreter without including pip
  2. Select that interpreter as the kernel in vscode and run a cell
  3. A prompt shows up saying that IPykernel and pip are required, select install

result:
image

This happened after deleting the windows app python installation, and installing a new 3.10.5 to replace it.

@amunger amunger added the bug Issue identified by VS Code Team member as probable bug label Jun 9, 2022
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Jun 9, 2022
@rchiodo
Copy link
Contributor

rchiodo commented Jun 9, 2022

I believe this is by design. You need to have pip available.

This issue is relevant:
microsoft/vscode-python#15937

@amunger
Copy link
Contributor Author

amunger commented Jun 9, 2022

we shouldn't have an option to install if we know it's going to fail, the installation prompt already says that pip is missing

@amunger
Copy link
Contributor Author

amunger commented Jun 9, 2022

image

@rchiodo
Copy link
Contributor

rchiodo commented Jun 9, 2022

We probably should not have the install button in this case. Without 'pip' we don't want to get pip for the user. They should do it but we need to make that clearer.

@rchiodo rchiodo added notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) papercut 🩸 Something affecting the productivity of the team notebook-getting-started and removed triage-needed Issue needs to be triaged labels Jun 9, 2022
@amunger
Copy link
Contributor Author

amunger commented Jun 9, 2022

I might be in this situation because of a bad python installation, pip should actually be installed

PS C:\src\test\3> python -m pip --version
Error processing line 7 of C:\Users\aamunger\AppData\Roaming\Python\Python310\site-packages\pywin32.pth:

  Traceback (most recent call last):
    File "C:\Users\aamunger\AppData\Local\Programs\Python\Python310_5\lib\site.py", line 186, in addpackage
      exec(line)
    File "<string>", line 1, in <module>
  ModuleNotFoundError: No module named 'pywin32_bootstrap'

Remainder of file ignored
C:\Users\aamunger\AppData\Local\Programs\Python\Python310_5\python.exe: No module named pip

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Aug 15, 2022

@IanMatthewHuff I'm taking this as this falls into installation, and kernel startup and the like.

I think the changes to ensure we display (recommend) the right interpeter int the kernel picker will probably alleviate this issue

@DonJayamanne DonJayamanne removed the papercut 🩸 Something affecting the productivity of the team label Dec 28, 2022
@DonJayamanne
Copy link
Contributor

Closing as not planned
No one else has reported this

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) notebook-getting-started
Projects
None yet
Development

No branches or pull requests

4 participants