Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise preferred kernel algorithm #12274

Closed
DonJayamanne opened this issue Dec 2, 2022 · 1 comment
Closed

Revise preferred kernel algorithm #12274

DonJayamanne opened this issue Dec 2, 2022 · 1 comment
Assignees
@DonJayamanne
Labels
notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) notebook-kernel-picker polish Cleanup and polish issue
Milestone
January 2023

Comments

@DonJayamanne
Copy link
Contributor

  • Only return a preferred kernel if we have an exact match
  • If we select a controller and then go into the kernle picker then the suggestion should not necessarily based off of the metadta (as the metadta gets updated to point to the selected controller)
  • Always give preference to local workspace environments
@DonJayamanne DonJayamanne added kernel-picker polish Cleanup and polish issue labels Dec 2, 2022
@DonJayamanne DonJayamanne added this to the December 2022 milestone Dec 2, 2022
@DonJayamanne DonJayamanne self-assigned this Dec 2, 2022
This was referenced Dec 4, 2022
Closed
Closed
@rebornix rebornix added notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) notebook-kernel-picker and removed kernel-picker labels Dec 9, 2022
@DonJayamanne
Copy link
Contributor Author

Done

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) notebook-kernel-picker polish Cleanup and polish issue
Projects
None yet
Milestone
January 2023
Development

No branches or pull requests
2 participants
@rebornix @DonJayamanne