Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The kernel picker did not update the loading icon after the check was complete #14158

Closed
realDuang opened this issue Aug 21, 2023 · 6 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s)

Comments

@realDuang
Copy link
Member

Environment data

  • VS Code version: 1.82.0 - Insider
  • Jupyter Extension version (available under the Extensions sidebar): v2023.8.1002321100
  • Python Extension version (available under the Extensions sidebar): v2023.15.12302115
  • OS (Windows | Mac | Linux distro) and version: Chrome web
  • Python and/or Anaconda version:
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...):
  • Jupyter server running: Remote

Expected behaviour

image

Actual behaviour

image

Steps to reproduce:

I am trying to use jupyter vscode extension under insiders.vscode.dev.

When I open any notebook, it occasionally appears that the kernel selector shows a loading icon, but the actual detect function is completed.

Then I check the jupyter log and find that the kernel picker detection runs properly.

I haven't found the exact path of recurrence yet, but the problem is there. It seems that the detection is actually completed before the UI update time is caused.

image

Logs

Output for Jupyter in the Output panel (ViewOutput, change the drop-down the upper-right of the Output panel to Jupyter)

Visual Studio Code - Insiders (1.82.0-insider, undefined, vscode.dev)
Jupyter Extension Version: 2023.8.1002321100.
Python Extension Version: 2023.15.12302115.
No workspace folder opened.
14:48:37.299 [info] User belongs to experiment group 'NewJupyterSession'
14:48:46.411 [error] Unable to determine the caller of the extension API for trace stack. Error: 
    at u.determineExtensionFromCallStack (https://ms-toolsai.vscode-unpkg.net/ms-toolsai/jupyter/2023.8.1002321100/extension/out/extension.web.bundle.js#vscode-extension:11:310457)
    at g (https://ms-toolsai.vscode-unpkg.net/ms-toolsai/jupyter/2023.8.1002321100/extension/out/extension.web.bundle.js#vscode-extension:26:113218)
    at Object.registerRemoteServerProvider (https://ms-toolsai.vscode-unpkg.net/ms-toolsai/jupyter/2023.8.1002321100/extension/out/extension.web.bundle.js#vscode-extension:26:113817)
    at _i.eval (https://github.vscode-unpkg.net/GitHub/codespaces/1.14.15/node_modules/js-sha256/src/sha256.js:1:1)
    at Generator.next (<anonymous>)
    at fulfilled (https://github.vscode-unpkg.net/GitHub/codespaces/1.14.15/node_modules/js-sha256/src/sha256.js:1:1)
14:48:46.414 [error] Unable to determine the caller of the extension API for trace stack. Error: 
    at u.determineExtensionFromCallStack (https://ms-toolsai.vscode-unpkg.net/ms-toolsai/jupyter/2023.8.1002321100/extension/out/extension.web.bundle.js#vscode-extension:11:310457)
    at eval (https://ms-toolsai.vscode-unpkg.net/ms-toolsai/jupyter/2023.8.1002321100/extension/out/extension.web.bundle.js#vscode-extension:26:114020)
    at Object.registerRemoteServerProvider (https://ms-toolsai.vscode-unpkg.net/ms-toolsai/jupyter/2023.8.1002321100/extension/out/extension.web.bundle.js#vscode-extension:26:114112)
    at _i.eval (https://github.vscode-unpkg.net/GitHub/codespaces/1.14.15/node_modules/js-sha256/src/sha256.js:1:1)
    at Generator.next (<anonymous>)
    at fulfilled (https://github.vscode-unpkg.net/GitHub/codespaces/1.14.15/node_modules/js-sha256/src/sha256.js:1:1)
14:48:51.963 [info] Start refreshing Kernel Picker (1692600531963)
14:48:52.860 [info] End refreshing Kernel Picker (1692600531963)
14:48:58.000 [info] Handle Execution of Cells 0 for /A8F6376E-193C-4729-B2E9-570B631961F5/b771c1ab-1696-4f34-aac1-fe4c1b81d925/bef3408a-8d26-413b-9c5d-956cbae04d1e/vscode-test.ipynb
14:48:58.002 [info] Starting Kernel startUsingRemoteKernelSpec, 725001538c52f828aa9114ee3c092d578790498546af01798de7d09dfaf960f6..synapse_pyspark./python3./.-m#synapsekernel.synapse_pyspark  for '/A8F6376E-193C-4729-B2E9-570B631961F5/b771c1ab-1696-4f34-aac1-fe4c1b81d925/bef3408a-8d26-413b-9c5d-956cbae04d1e/vscode-test.ipynb' (disableUI=false)
14:48:59.075 [info] https://a8f6376e193c4729b2e9570b631961f5.pbidedicated.windows.net/webapi/capacities/A8F6376E-193C-4729-B2E9-570B631961F5/workloads/Notebook/Data/Direct/api/workspaces/b771c1ab-1696-4f34-aac1-fe4c1b81d925/artifacts/bef3408a-8d26-413b-9c5d-956cbae04d1e/jupyterApi/versions/1: Kernel started: 5b11c4fe-1d74-43cc-8ae7-43c98934cca8
14:49:00.291 [info] Started session for kernel startUsingRemoteKernelSpec:725001538c52f828aa9114ee3c092d578790498546af01798de7d09dfaf960f6..synapse_pyspark./python3./.-m#synapsekernel.synapse_pyspark
14:49:13.400 [info] Start refreshing Kernel Picker (1692600553400)
14:49:13.933 [info] Kernel acknowledged execution of cell 0 @ 1692600552741
14:49:14.204 [info] End refreshing Kernel Picker (1692600531963)
14:49:14.205 [info] End refreshing Kernel Picker (1692600553400)
14:49:14.986 [info] End cell 0 execution @ 1692600553518, started @ 1692600552741, elapsed time = 0.777s

@realDuang realDuang added the bug Issue identified by VS Code Team member as probable bug label Aug 21, 2023
@amunger
Copy link
Contributor

amunger commented Aug 21, 2023

but the actual detect function is completed.
What are you basing this off of? the "End refreshing Kernel picker" log?

How long does the loading icon show after the refresh completes? a few seconds?

@amunger amunger added the info-needed Issue requires more information from poster label Aug 21, 2023
@realDuang
Copy link
Member Author

but the actual detect function is completed.
What are you basing this off of? the "End refreshing Kernel picker" log?

How long does the loading icon show after the refresh completes? a few seconds?

No, it's stuck at the loading state for a long time and never change it unless I restart vscode

@amunger amunger assigned DonJayamanne and unassigned amunger Aug 22, 2023
@amunger amunger removed the info-needed Issue requires more information from poster label Aug 22, 2023
@DonJayamanne
Copy link
Contributor

Based on the logs Jupyter extension is done with the kernel refresh

@rebornix rebornix added this to the On Deck milestone Oct 3, 2023
@realDuang
Copy link
Member Author

Kindly ping on this. Is there any update here?

@realDuang
Copy link
Member Author

@rebornix This issue is still bothering us. if you have a moment please check back to see if there is any further progress, or information you would like me to provide.

@rebornix rebornix added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 8, 2023
@rebornix rebornix modified the milestones: On Deck, December 2023 Dec 8, 2023
@rebornix
Copy link
Member

rebornix commented Dec 8, 2023

Let's merge it into microsoft/vscode#186364, will tackle this soon.

@rebornix rebornix closed this as completed Dec 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

4 participants