Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we deal with user code (packages) causing kernel failures #9375

Closed
DonJayamanne opened this issue Mar 15, 2022 · 3 comments · Fixed by #9587
Closed

Can we deal with user code (packages) causing kernel failures #9375

DonJayamanne opened this issue Mar 15, 2022 · 3 comments · Fixed by #9587
Assignees
Labels
verification-steps-needed Steps to verify are needed for verification verified Verification succeeded
Milestone

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Mar 15, 2022

Misc:

Suggestions

  • Improve error message dispalyed in the popup
    • When kernel crashes provide a more meaningful message about what happened, users might not know what a kernel is, hence might ignore the error message or wouldn't be able to connect execution of cell to an error message about kernel failure
  • Include error message in cell output
    • This way they know what cell caused the failure
  • Should we pay specific focus to packages such as tensorflow, numpy, fastparquet (and provide a link to a Wiki)
    • Note: We do this today for kernel startup failures (e.g. if we have a DLL exception, we provide error information and a link to a WIKI)
    • Provide instructions in the error output specific to some packages (with links to WIKI)
@rchiodo
Copy link
Contributor

rchiodo commented May 3, 2022

@DonJayamanne do you have verification steps for this issue?

@rchiodo rchiodo added the verification-steps-needed Steps to verify are needed for verification label May 3, 2022
@DonJayamanne
Copy link
Contributor Author

Run a cell with the following code (cause the kernel to crash)

import IPython
app = IPython.Application.instance()
app.kernel.do_shutdown(True)

Output should contrain a link to wiki as follows:
Screen Shot 2022-05-04 at 06 02 31

@rchiodo
Copy link
Contributor

rchiodo commented May 3, 2022

So this is the same fix as #9588.

/verified

@rchiodo rchiodo added the verified Verification succeeded label May 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
verification-steps-needed Steps to verify are needed for verification verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants