Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SelectionRange and SelectionRangeKind to types #460

Closed
aeschli opened this issue Feb 13, 2019 · 4 comments
Closed

Move SelectionRange and SelectionRangeKind to types #460

aeschli opened this issue Feb 13, 2019 · 4 comments
Assignees

Comments

@aeschli
Copy link
Contributor

aeschli commented Feb 13, 2019

SelectionRange and SelectionRangeKind should go into types

@dbaeumer
Copy link
Member

I have to say that I don't like the type package anymore. Makes my live unnecessary complicated :-)

@rcjsuen
Copy link
Contributor

rcjsuen commented Apr 21, 2019

I use this package exclusively to separate out the language service logic and the language server logic. So I like it anyway. :P

@dbaeumer
Copy link
Member

I can move them if the selection range becomes stable. The type package has no proposed support :-(.

@dbaeumer
Copy link
Member

This got magically done :-)

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants