Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensionless "typings" entries in package.json no longer work as of TypeScript 2.1.0-dev.20160820 #76

Closed
rbuckton opened this issue Aug 22, 2016 · 2 comments

Comments

@rbuckton
Copy link
Member

A recent change in TypeScript has caused a breaking change that affects the vscode-languageserver, vscode-languageserver-types, vscode-languageclient and vscode-jsonrpc packages. Specifically, extensions are now required in the "typings" field in package.json. These packages all have something like the following in their package.json files:

"typings": "lib/main"

Due to this change, all of these references must instead now point to something like the following:

"typings": "lib/main.d.ts"
@rbuckton rbuckton changed the title extensionless "typings" entries in package.json no longer work as of TypeScript 2.1.0-dev.20160820 Extensionless "typings" entries in package.json no longer work as of TypeScript 2.1.0-dev.20160820 Aug 22, 2016
@mhegazy
Copy link

mhegazy commented Aug 22, 2016

TS should not be breaking this scenario. @andy-ms can you take a look at the original change.

@rbuckton
Copy link
Member Author

Fixed in #10480

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants