Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ES6 Modules #56

Open
JustinGrote opened this issue Feb 29, 2024 · 9 comments
Open

Support ES6 Modules #56

JustinGrote opened this issue Feb 29, 2024 · 9 comments
Labels
feature-request Request for new features or functionality

Comments

@JustinGrote
Copy link

Now that VSCode is on Electron 28 which has ESM support, the loaders need to be updated similarly to allow for extensions to be written in ESM
microsoft/vscode#130367 (comment)

@alexdima alexdima added the feature-request Request for new features or functionality label Mar 20, 2024
@Mr-Duda
Copy link

Mr-Duda commented May 3, 2024

This would be very helpful since microsoft/vscode#210466 is now live.

@v4lentin1879
Copy link

any updates on this one?

@Mr-Duda
Copy link

Mr-Duda commented May 26, 2024

I think this is also related: microsoft/vscode#212727

@v4lentin1879
Copy link

v4lentin1879 commented May 26, 2024

any idea when this is gonna be implemented? It seems like there is no possibility of importing esm modules in commonjs without using a dynamic import.. which again is not supported by vscode

@alexander-heimbuch
Copy link

@v4lentin1879 the PR @wataBottl referenced looks interesting. I don't think it will get merged but it seems to be possible.

@v4lentin1879
Copy link

@alexander-heimbuch okay at least something :D Do you have any idea how to do this? Using dynamic imports only works in debug mode.

@alexander-heimbuch
Copy link

@v4lentin1879 it looks like it does require a change in the extension loader in core, without it I don't think it possible (or I couldn't manage to get it working).

@JustinGrote
Copy link
Author

JustinGrote commented Oct 31, 2024

@alexdima are you tracking any work on this?

@tats-u
Copy link

tats-u commented Nov 18, 2024

Is the blocker the lack of stability of require(esm) or vm.Modules?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

6 participants