Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

bundleMetadataFiles on windows, uses backslashes in module names #19

Closed
roblourens opened this issue Mar 25, 2018 · 4 comments
Closed

Comments

@roblourens
Copy link
Member

When I pull from Transifex on a mac, I get files with backslashes in their names, because they are not interpreted as directory separators

@roblourens
Copy link
Member Author

@dbaeumer Can you tell whether there's something wrong with my configuration that's causing this? I don't get this for the other debug repos, which have simpler gulpfiles, but I shouldn't have to fix the slashes outside of vscode-nls-dev.

@dbaeumer
Copy link
Member

dbaeumer commented Apr 3, 2018

I will have a look. Usually we combine paths with path.join to avoid these problems.

@roblourens
Copy link
Member Author

roblourens commented Apr 3, 2018

On windows path.join will use backslashes, this is only happening from windows.

@dbaeumer
Copy link
Member

Fixed in vscode-nls-dev. The problem was that we correctly used '/' even on windows to combine things but we didn't change the slash in the path under Windows.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants