Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Device Auth Flow #3325

Closed
colemickens opened this issue Feb 16, 2022 · 4 comments
Closed

Support Device Auth Flow #3325

colemickens opened this issue Feb 16, 2022 · 4 comments

Comments

@colemickens
Copy link

Uh. Where is the documentation covering vscode-auth and why it's necessary?

Why does this extension seem to intentionally not support any other OAuth flow that might be more usable than expecting to be able to POST back to a browser or private URL? (Especially when past issues refer to a workaround that allowed PATs?)

@colemickens
Copy link
Author

I guess the context is here: #93

It's too bad that GitHub doesn't have manual authorization code support.

I think this extension should, at the very least, support manual tokens and support the beta device auth flow rather than MITMing (whether it has access to them or not) user github tokens.

@colemickens colemickens changed the title Document Authentication design Support Device Auth Flow Feb 16, 2022
@colemickens
Copy link
Author

Octokit already supports this auth flow as well (but it also supports PATs...).

@colemickens
Copy link
Author

Wow, what a nightmare, this uses the builtin github auth provider which... doesn't seem great from first glance. Doesn't use octokit, hardcodes web callback auth.

anyway, guess this issue isn't here after all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant