Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing command in devcontainer.json marked as linting error #2231

Closed
connor4312 opened this issue Jan 28, 2020 · 0 comments
Closed

Trailing command in devcontainer.json marked as linting error #2231

connor4312 opened this issue Jan 28, 2020 · 0 comments
Assignees
@chrmarti
Labels
bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers verified Verification succeeded
Milestone
January 2020

Comments

@connor4312
Copy link
Member

connor4312 commented Jan 28, 2020 •
edited
Loading

Testing #2207. It's quite minor, but I notice that trailing commas in the devcontainer.json show as warnings. Most other JSON config in VS Code (launch.json, settings, etc.) allow trailing commas.

image
@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers labels Jan 29, 2020
@chrmarti chrmarti modified the milestones: February 2020, January 2020 Jan 29, 2020
chrmarti added a commit to microsoft/vscode that referenced this issue Jan 30, 2020
@chrmarti
Allow trailing comma (microsoft/vscode-remote-release#2231)
c27b6b0
@alexr00 alexr00 added the verified Verification succeeded label Jan 31, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers verified Verification succeeded
Projects
None yet
Milestone
January 2020
Development

No branches or pull requests
3 participants
@connor4312 @chrmarti @alexr00