Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test additional portsAttributes #4719

Closed
3 tasks done
alexr00 opened this issue Mar 22, 2021 · 1 comment
Closed
3 tasks done

Test additional portsAttributes #4719

alexr00 opened this issue Mar 22, 2021 · 1 comment

Comments

@alexr00
Copy link
Member

alexr00 commented Mar 22, 2021

Refs: #4623

Complexity: 3

Create Issue


  1. Connect to a remote. For step 2, your remote must be linux. All other steps can be tested with a Windows remote if you wish. Anything other than WSL is good for testing.
  2. The setting remote.portsAttributes is not new this iteration, but it now accepts a regex as a property. This regex will match on the cmdline of discovered ports (if you're using SSH open your Machine user settings and set remote.autoForwardPortsSource to process then reload to get cmdline association). Read the setting and make sure it's clear. Try out this new regex property. For example,
  • Open the microsoft/vscode-remote-try-node sample.
  • F5 or run npm run start. Look at the running process associated with your port in the Ports view.
  • Make a regex that will match that running process and add it to your remote.portsAttributes setting. Note that the devcontainer.json for this repo modifies this setting in your machine user settings, so you'll need to either delete that setting or modifier it there.:
".+\\/server.js": {
 "onAutoForward": "openPreview"
}
  • Stop your listening process and restart it again. Verify that your onAutoForward behavior is respected.
  1. The setting remote.unconfiguredPortsAttributes (The name of this setting has been changed to remote.otherPortsAttributes based on feedback. If you are testing on a newer build than a6f6b4aa8e3a688d9a5cbcd5df14af511ce2bd8e then you'll need this new name.) is new this iteration. Verify that it's description is clear. Try out the setting, and verify that it is respected.
@alexr00 alexr00 added this to the March 2021 milestone Mar 22, 2021
@ghost ghost assigned rebornix, isidorn and deepak1556 Mar 23, 2021
@isidorn
Copy link

isidorn commented Mar 23, 2021

I already had a test plan item for ports on LInux so I assigned myself to Linux to preserve setup and moved @deepak1556 to Windows. I hope that is fine, I checked your platform availablility and Win should be ok for you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants