Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Playwright an optional dependency #37

Open
christian-bromann opened this issue Jul 28, 2022 · 3 comments
Open

Make Playwright an optional dependency #37

christian-bromann opened this issue Jul 28, 2022 · 3 comments

Comments

@christian-bromann
Copy link

Howdy 👋

I am maintaining WebdriverIO and build a VS Code test plugin for it called wdio-vscode-service. It offers pretty much what @vscode/test-web and @vscode/test-electron do combined with a versatile test framework like WebdriverIO.

It would my life tremendously easier if this package could get rid of the Playwright dependency, which is only used to start up Chromium. There are other packages doing the same job using the actual Chrome browser installed on the system. It would also reduce installation time.

I am happy to make this change. It would allow me to use all the logic to spin up a VS Code server for testing web extensions.

Cheers!

@christian-bromann
Copy link
Author

Any comments?

@yiliang114
Copy link
Contributor

I think it is good.

@zm-cttae-archive
Copy link

zm-cttae-archive commented Feb 5, 2023

I have also hit this issue when I tried to bundle it up with Webpack.

Because this dep breaks bundling, that makes it much harder to use targeting web extensions...

For Webpack, it's possible to hack around it by only packing the test runner.


Examples ready to copy:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants