Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings/Paths for react/index.d.ts are not correctly generated #455

Closed
erkenberg opened this issue Feb 22, 2023 · 2 comments · Fixed by #456
Closed

Typings/Paths for react/index.d.ts are not correctly generated #455

erkenberg opened this issue Feb 22, 2023 · 2 comments · Fixed by #456
Assignees
Labels
bug Something isn't working

Comments

@erkenberg
Copy link

Describe the bug

npm run build generates a react/index.d.ts which uses incorrect paths in the current version (1.2.1):

E.g. (occurs multiple times in the file):

export declare const VSCodeBadge: [...] <import("../dist/dist/index.js") ...

To reproduce

  1. Clone the repository
  2. run npm install && npm run build
  3. check the generated react/index.d.ts

Expected behavior

dist only appears once on the path, as it was the case before this commit acadb09:

export declare const VSCodeBadge: [...] <import("../dist/index.js") ...

Current behavior

Starting with the linked commit and later, dist appears twice in the path, which is incorrect, as the path ../dist/dist/... does not exist.

Desktop (please complete the following information):

  • OS Version: macOS 13.2.1
  • Toolkit Version: v1.2.1
@hawkticehurst
Copy link
Member

Thanks for the catch @erkenberg! Just merged a PR that should fix the issue and will publish a patch release shortly

@erkenberg
Copy link
Author

Awesome, thanks for the quick fix @hawkticehurst !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants