Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a short delay before debug toolbar appears #101018

Closed
gjsjohnmurray opened this issue Jun 25, 2020 · 5 comments
Closed

Consider adding a short delay before debug toolbar appears #101018

gjsjohnmurray opened this issue Jun 25, 2020 · 5 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Milestone

Comments

@gjsjohnmurray
Copy link
Contributor

Using the latest vscode-mock-debug in a VS Code - OSS that I just built from master, the Run button makes the debug toolbar appear, then change, then disappear when the run has ended.

junk

Can anything be done to prevent this unnecessary activity>

Originally posted by @gjsjohnmurray in #92269 (comment)

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Jun 25, 2020
@isidorn isidorn added this to the Backlog milestone Jun 25, 2020
@isidorn
Copy link
Contributor

isidorn commented Jun 25, 2020

Thanks for creating this issue! I think what you are saying and it makes sense. We should show the toolbar with a slight delay, now the open question is when to show it with a delay and when to immediatly show it.

@weinand
Copy link
Contributor

weinand commented Jun 25, 2020

The toolbar must become visible on first change. E.g. the debugger breaks and the "pause" button turns into a "continue" button. If nothing is happening, it is OK to show the toolbar after a delay, e.g. 300 ms.

@isidorn
Copy link
Contributor

isidorn commented Jun 25, 2020

We can do that. But what is the right number, because 300ms for example would still show the debug toolbar in the examlpe above, it would just be shorter and look more like a UX glitch.

@weinand
Copy link
Contributor

weinand commented Jun 25, 2020

The question is: what delay are users willing to accept when they start a debug session and are not immediately hitting a breakpoint.

@isidorn
Copy link
Contributor

isidorn commented Aug 18, 2020

Let's close as dup of #84228

@isidorn isidorn closed this as completed Aug 18, 2020
@isidorn isidorn added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 18, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants