Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Single SCM view #101302

Closed
2 tasks done
joaomoreno opened this issue Jun 29, 2020 · 0 comments
Closed
2 tasks done

Test: Single SCM view #101302

joaomoreno opened this issue Jun 29, 2020 · 0 comments

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Jun 29, 2020

Refs: #90461

Complexity: 4

Create Issue


Before you start, please keep in mind to consult the existing issues before filling new ones.

SCM used to allocate one workbench view per repository; it now is able to show all data in a single view. You're supposed to run a more or less thorough SCM smoke test, but here are some pointers:

  • The single repository view should work pretty much as before expect for the hopefully insignificant fact that the input box now scrolls with the tree. 🤫
  • As for the multiple repository view:
    • All repositories should be represented in the tree, including their respective status bar actions as well as contextual actions
    • Clicking around the view should influence which repository appears in the status bar. The same goes for switching the active file in the editor
    • It should still be possible to switch between rendering the contents as a tree or list
  • The input box is a monaco editor: it should still automatically grow with its content (up to a certain max) as well as render widgets (suggest widget) and validation (have a commit message comprised of only whitespace to see a warning)
  • The welcome view should work as before, eg open a new window and see if welcome view content shows up
  • Move the view around, into another viewlet and panel
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants