-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] - Toggle Custom Editor (Improved markdown support) #113298
Comments
(Experimental duplicate detection) |
@jasonwilliams @mjbvz . I would like to tackle this if it's not been worked on yet. |
@olajohn-ajiboye no one is working on this so feel free! |
Thanks @jasonwilliams , I will start working on this. Am I able to ask for pointers from you if I need additional clarifications or who else can help? |
@olajohn-ajiboye sure you can ask here. @mjbvz should hopefully be able to guide you too as he made the parent issue and created the custom editor |
The existing To start, look at the
For the new command, you'll also want to save off the new setting. Here's an example of some code that does that:
|
Thanks for the heads-up @mjbvz , I will have another look at this. |
Hey @jasonwilliams @mjbvz , I am not able to reproduce the "Reopen Editor with..." option. I was able to see this option before, but it seems gone. Could this be due to an update? |
@olajohn-ajiboye what version of VSCode are you using? Are you using insiders or stable? |
@jasonwilliams it's Version: 1.52.1. I am not sure if it's stable or insider. |
@mjbvz you able to do something about that? ^ |
@olajohn-ajiboye maybe it’s only on insiders |
Can we reopen this? It’s being looked at |
@mjbvz what's the purpose of |
|
@mjbvz is this issue still valid? |
Thanks @jasonwilliams. Yes I'll close this since I think this was addressed. Please open new issues if some part of this still isn't working as expected |
This issue arises from the parent issue: #84520
Description
I would like to quickly toggle between 2 markdown states:
Toggling between modes should take place in the same current window. This way you'll get a smooth create-read-modify experience. For references have a look at typora.io or notable.md where this is perfectly implemented.
Persistent State
When toggling between 2 states i would like the states to be persistent.
What i mean by this, is if I toggle a document to preview mode, when I go to open another document, I'm still in preview mode until I toggle back. This is the behaviour of many other markdown viewers and is pretty standard at this point, if it can keep state across sessions that would be even better.
Steps to reproduce:
Add this to your settings:
Then open a markdown file, you can toggle state by calling "Reopen Editor with..." then selecting one of the 2 options. Opening a new file resets this choice.
Requested changes
As per the discussion in #84520 we would like to see a keyboard-shortcut which can toggle between these 2 states, and keep persistence.
Implementation detail
#84520 (comment)
The text was updated successfully, but these errors were encountered: