Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reveal = Never/Silent not respected when running task programmatically #116015

Closed
spmeesseman opened this issue Feb 7, 2021 · 4 comments
Closed
Assignees
Labels
*not-reproducible Issue cannot be reproduced by VS Code Team member as described

Comments

@spmeesseman
Copy link

spmeesseman commented Feb 7, 2021

  • VSCode Version: 1.53
  • OS Version: Windows 10

Steps to Reproduce:

  1. Create an instance of Task
  2. Set instance.presentationOptions.reveal = TaskRevealKind.Never (or TaskRevealKind.Silent)
  3. Call vscode.tasks.executeTask()

Does this issue occur when all extensions are disabled?: Yes

Looks like same issue as #66749 back again?

Expected Behavior: No terminal should open
Actual Behavior: Terminal opens no matter what

Example:

private async run(task: Task)
{
    task.presentationOptions.reveal = TaskRevealKind.Never; // or TaskRevealKind.Silent
    try {
        await vscode.tasks.executeTask(task);
    }
    catch (e) {
}
@vscodebot
Copy link

vscodebot bot commented Feb 7, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@gjsjohnmurray
Copy link
Contributor

/assign @alexr00

@alexr00
Copy link
Member

alexr00 commented Feb 8, 2021

I am not able to repro this issue. My test code:

	const disposable = vscode.commands.registerCommand('extension.helloWorld', () => {
		const task = new vscode.Task(
			{ type: 'shell' }, vscode.workspace.workspaceFolders![0], 'myTask',
			'myExt', new vscode.ShellExecution('dir'));
		task.presentationOptions.reveal = vscode.TaskRevealKind.Silent;
		vscode.tasks.executeTask(task);
	});

I also tested with TaskRevealKind.Never. The terminal is not shown.

@alexr00 alexr00 added the *not-reproducible Issue cannot be reproduced by VS Code Team member as described label Feb 8, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*not-reproducible Issue cannot be reproduced by VS Code Team member as described
Projects
None yet
Development

No branches or pull requests

4 participants
@gjsjohnmurray @alexr00 @spmeesseman and others