Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spdlog: Loading non-context-aware native module in renderer #120159

Closed
bpasero opened this issue Mar 30, 2021 · 1 comment
Closed

spdlog: Loading non-context-aware native module in renderer #120159

bpasero opened this issue Mar 30, 2021 · 1 comment
Assignees
@sandy081
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders shared-process VS Code shared process issues
Milestone
April 2021

Comments

@bpasero
Copy link
Member

bpasero commented Mar 30, 2021

It looks like we are still bringing in spdlog as dependency into a renderer. My understanding is that in the future Electron will not allow this anymore (electron 13?). I think we should use the already existing electron-main support for logging also from the shared process.

//cc @deepak1556
@bpasero bpasero added debt Code quality issues shared-process VS Code shared process issues labels Mar 30, 2021
@sandy081 sandy081 added this to the April 2021 milestone Mar 30, 2021
@bpasero
Copy link
Member Author

bpasero commented Mar 30, 2021

👏

@bpasero bpasero mentioned this issue Apr 3, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders shared-process VS Code shared process issues
Projects
None yet
Milestone
April 2021
Development

No branches or pull requests
3 participants
@bpasero @sandy081 and others