Hot Exit: Restore files after an editor crashes

[BirdLeeSCUT]

Vscode is so excellent , we love it very much! But this days vscode still has some bugs making it crash, especially when I work with big project that open so many files at the same time. And when vscode reopenes after crashed, the file openning status rolls back to that when I openned it last time, not the status when it alert "no responding". This make some inconvenience for us to contunue our work. So I hope vscode can save the file openning status when it crash.

[chrmarti]

Related to #101

[Tyriar]

I'm going to track this feature separately to #101

[Tyriar]

I believe this is mostly working after progress in #101, it will currently not attempt to restore the changes until VS Code has been completely exited though. We probably want a dialog asking whether the user wants to restore.

[bpasero]

Needs #15718

[bpasero]

@Tyriar should we look into enabling this scenario now that I landed 6422acb ?

Imho the only thing needed is to remove the checks for hot exit being enabled in backupModelTracker.

[Tyriar]

The checks must remain for the extension development case. I suggest we support crash recovery on empty workspaces when we support hot exit on empty workspaces (which should be soon). #13733

[bpasero]

@Tyriar sure for extension development we can have another check to not do backups. I am not sure how crash recovery and empty workspaces are related, I could have a folder opened with dirty files and a crash takes down my changes. I would want them to restore even if hot exit is disabled.

[Tyriar]

Backups should be happening all the time now due to empty workspace restore 🎆

[bpasero]

@Tyriar does not work for me:

• make some files dirty
• kill the process
• restart
  => no restore

I think you still check for isHotExitEnabled in backupModelTracker.ts?

[Tyriar]

Test plan #16544