Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Reporter Does Not Like Line Breaks #124340

Closed
hediet opened this issue May 21, 2021 · 6 comments
Closed

Error Reporter Does Not Like Line Breaks #124340

hediet opened this issue May 21, 2021 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster

Comments

@hediet
Copy link
Member

hediet commented May 21, 2021

I'm using the latest VS Code & latest Windows.

This is what the terminal reports (VS Code - Build task):
image

This is the reported problem:

image

Notice the vertical space. When I click on it, VS Code does not find the file.

@hediet hediet added the bug Issue identified by VS Code Team member as probable bug label May 21, 2021
@hediet hediet changed the title Terminal Error Provider Does Not Like Line Breaks Error Reporter Does Not Like Line Breaks May 21, 2021
@Tyriar
Copy link
Member

Tyriar commented May 21, 2021

@hediet what build of windows are you on? Run ver in terminal

@meganrogge meganrogge added the info-needed Issue requires more information from poster label May 24, 2021
@hediet
Copy link
Member Author

hediet commented May 31, 2021

I'm sorry, totally forgot about this.

C:\dev>ver

Microsoft Windows [Version 10.0.19043.985]

@hediet hediet reopened this May 31, 2021
@meganrogge meganrogge removed the info-needed Issue requires more information from poster label Jun 1, 2021
@meganrogge
Copy link
Contributor

Are you still seeing this?

@meganrogge meganrogge added the info-needed Issue requires more information from poster label Jun 1, 2021
@hediet
Copy link
Member Author

hediet commented Jun 2, 2021

Unfortunately, yes!

recording

This is the text from the terminal (some parts of it are really scrambled, I used copy & paste):

> Executing task: yarn run watch-clientd <

yarn run v1.22.10
$ deemon yarn watch-client$ node --max_old_space_size=4095 ./node_modules/gulp/bin/gulp.js watch-client
[09:25:39][09:25:39] Using gulpfile C:\dev\microsoft\vscode\gulpfile.js
[09:25:39] Starting 'watch-client'...
[09:25:39] Starting clean-out ...
[09:25:40][09:25:40] Finished clean-out after 819 ms[09:25:40] Starting watch-client ...      
[09:25:43] Starting compilation...
ch-client'...
[09:25:39] Starting clean-out ...
[09:25:40] Finished clean-out after 819 ms
[09:25:40] Starting watch-client ...
[09:25:43] Starting compilation...
[09:27:13] Finished compilation with 0 errors after 89708 ms
[09:27:13] Starting compilation...
[09:27:14] Error: C:/dev/microsoft/vscode/src/vs/editor/contrib/hover/modesContentHover.ts(56,9): Property 'addAction' in type 'EditorHoverStatusBar' is not assignable to the same property in base type 'IEditorHoverStatusBar'.
  Type '(actionOptions: { labela: string; iconClass?: string | undefined; run: (target: HTMLElement) => void; commandId: string; }) => void' is not assignable to type '(actionOptions: { label: string; iconClass?: string | undefined; run: (target: HTMLElement) => void; commandId: string; }) => void'.
    Types of parameters 'actionOptions' and 'actionOptions' are incompatible.     
      Property 'labela' is missing in type '{ label: string; iconClass?: string | 
undefined; run: (target: HTMLElement) => void; commandId: string; }' but required 
in type '{ labela: string; iconClass?: string | undefined; run: (target: HTMLElement) => void; commandId: string; }'.
[09:27:14] Error: C:/dev/microsoft/vscode/src/vs/editor/contrib/hover/modesContentHover.ts(59,57): Argument of type '{ labela: string; iconClass?: string | undefined; run: (target: HTMLElement) => void; commandId: string; }' is not assignable to parameter of type '{ label: string; iconClass?: string | undefined; run: (target: HTMLElement) => void; commandId: string; }'.
  Property 'label' is missing in type '{ labela: string; iconClass?: string | undefined; run: (target: HTMLElement) => void; commandId: string; }' but required in type '{ label: string; iconClass?: string | undefined; run: (target: HTMLElement) => void; commandId: string; }'.
[09:27:14] Error: C:/dev/microsoft/vscode/src/vs/editor/contrib/hover/modesContentHover.ts(544,82): Argument of type 'EditorHoverStatusBar' is not assignable to parameter of type 'IEditorHoverStatusBar'.
  Types of property 'addAction' are incompatible.
    Type '(actionOptions: { labela: string; iconClass?: string | undefined; run: (target: HTMLElement) => void; commandId: string; }) => void' is not assignable to type '(actionOptions: { label: string; iconClass?: string | undefined; run: (target: HTMLElement) => void; commandId: string; }) => void'.
[09:27:14] Finished compilation with 3 errors after 696 ms
[09:27:40] Starting compilation...
[09:27:42] Finished compilation with 0 errors after 1504 ms
[09:27:49] Starting compilation...
[09:27:49] Error: C:/dev/microsoft/vscode/src/vs/editor/contrib/hover/modesContentHover.ts(56,9): Property 'addAction' in type 'EditorHoverStatusBar' is not assignable to the same property in 
base type 'IEditorHoverStatusBar'.
  Type '(actionOptions: { label: string; iconClass?: string | undefined; runa: (target: HTMLElement) => void; commandId: string; }) => void' is not assignable to type '(actionOptions: { label: string; iconClass?: string | undefined; run: (target: HTMLElement) => void; commandId: string; 
}) => void'.
    Types of parameters 'actionOptions' and 'actionOptions' are incompatible.
      Property 'runa' is missing in type '{ label: string; iconClass?: string | undefined; run: 
(target: HTMLElement) => void; commandId: string; }' but required in type '{ label: string; iconClass?: string | undefined; runa: (target: HTMLElement) => void; commandId: string; }'.
ns: { label: string; iddActioatusB?: string | undefinor/contrib/hover/modesContentHover.ts(59,57conClass?: string | un       meter> void; commandIdsting | undefined; runa: (target: HTMLElementdefined; runa: (targetns: { lar'.                     parameter of type '{ label: string; iconCl: HTMLElement) => voids?: strn' ar/vscode/src/vs/edit=> void; commandId: string; }'.; commandId: string; } (targe     er.ts(544,82): Arme iconClass?: string | undefined; runa: (tar) => void' is not assid; commabel:ar' is not assign trequired in type '{ label: string; iconClasgnable to type '(actiooid' is undeHoverStatusBar'.    void; commandId: string; }'.nOptions: { label: stre '(actment)e incompatible.    or/contrib/hover/modesContentHover.ts(544,8ing; iconClass?: strintring; }) => string; iconClass?signable to parameter of type 'IEditorHoverg | undefined; run: (tndefineype 'get: HTMLElement)> arget: HTMLElement) =>lement)ng; i void' is not assbl void; commandId: stritring; ; run label: string; iss: string | undefined; runa: (target: HTMLElng; }) => void'.             id; c: (target: HTMLEl>  assignable to type '(actionOptions: { labe
[09:27:49] Finished compilati.     }) => void'.      et: HTMLElement) => void; commandId: stringmpilation with 3 error 552 mson with 3 errors after 5s after 552 ms                                       52 ms
[09:28:12] Starting compilation...
[09:28:12] Error: C:/dev/microsoft/vscode/src/vs/editor/contrib/hover/modesContentHover.ts(56,9): Property 'addAction' in type 'EditorHoverStatusBar' is not assignable to the same property in base type 'IEditorHoverStatusBar'.
  Type '(actionOptions: { label: string; iconClass?: string | undefined; run: (target: HTMLElement) => void; commandIda: string; }) 
=> void' is not assignable to type '(actionOptions: { label: string; iconClass?: string 
| undefined; run: (target: HTMLElement) => void; commandId: string; }) => void'.        
    Types of parameters 'actionOptions' and 
'actionOptions' are incompatible.
      Property 'commandIda' is missing in type '{ label: string; iconClass?: string | undefined; run: (target: HTMLElement) => void; commandId: string; }' but required in type 
'{ label: string; iconClass?: string | undefined; run: (target: HTMLElement) => void; commandIda: string; }'. 
[09:28:12] Error: C:/dev/microsoft/vscode/src/vs/editor/contrib/hover/modesContentHover.ts(57,77): Property 'commandId' does not exist on type '{ label: string; iconClass?: string | undefined; run: 
(target: HTMLElement) 
=> void; commandIda: string; }'. Did you mean 'commandIda'?       
[09:28:12] Error: C:/dev/microsoft/vscode/src/vs/editor/contrib/hover/modesContentHover.ts(59,57): Argument of type '{ label: string; iconClass?: string | undefined; run: (target: HTMLElement) => void; commandIda: string; }' is not assignable to parameter of type 
'{ label: string; iconClass?: string | undefined; run: (target: HTMLElement) => void; commandId: string; }'.  
  Property 'commandId' is missing in type '{ label: string; iconClass?: string | undefined; run: (target: HTMLElement) => void; commandIda: string; }' but required in type '{ label: string; iconClass?: string | undefined; run: (target: HTMLElement) => void; commandId: string; }'.      
[09:28:12] Error: C:/dev/microsoft/vscode/src/vs/editor/contrib/hover/modesContentHover.ts(544,82): Argument of type 'EditorHoverStatusBar' is not assignable to parameter of type 'IEditorHoverStatusBar'.
  Types of property 'addAction' are incompatible.
    Type '(actionOptions: { label: string; iconClass?: string | undefined; run: (target: HTMLElement) => void; commandIda: string; }) => void' is not assignable to type '(actionOptions: { label: string; iconClass?: string | undefined; run: (target: HTMLElement) => void; commandId: string; }) => void'.      
[09:28:12] Finished compilation with 4 errors after 578 ms        

This is how it is rendered:
recording

These are the errors:
image

The likelyhood of this happening increases when decreasing the width of the terminal.

@Tyriar
Copy link
Member

Tyriar commented Jun 2, 2021

There's probably not much we can do about this, I believe you're hitting the limits of our line wrapping heuristic where since old conpty doesn't support line wrapping we assume a link is wrapped if the last character in the row is non-whitespace. Reducing the width of the terminal will increase the chance of a line-ending space which results in a failure. @meganrogge has worked on the fix for this but you'll need to wait until Windows build 21376 #91898

@Tyriar Tyriar closed this as completed Jun 2, 2021
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

4 participants
@Tyriar @hediet @meganrogge and others