Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete files action deletes wrong file if the cursor (the blue border?) is not on the selected files. #124611

Closed
andyhohorst-highgear opened this issue May 25, 2021 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) file-explorer Explorer widget issues

Comments

@andyhohorst-highgear
Copy link

Issue Type: Bug

Steps to reproduce:

  • Open a folder in VS Code
  • Select multiple files
  • Ctrl-click to deselect one or more files
  • Press DELETE key
  • Prompt and delete action work on the most recently deselected file (whichever one has the border)

Expected: That selecting a set of files and pressing DELETE would work on the complete selection, regardless of the steps taken to get to that selection.

The delete action works as expected as long as the blue border is on part of the selected set of files. If the most recently selected/deselected file is not part of the selected set of files, it is treated as the only file selected.

image
image

VS Code version: Code - Insiders 1.57.0-insider (286b643, 2021-05-25T05:24:28.413Z)
OS version: Windows_NT x64 10.0.19042

System Info
Item Value
CPUs Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz (12 x 2208)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 39.75GB (19.40GB free)
Process Argv --crash-reporter-id 4e2c608a-5566-4ff8-9bed-2d58870e9773
Screen Reader no
VM 0%
Extensions: none
A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
pythonvspyt602:30291494
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30291487
pythontb:30258533
pythonvspyt551cf:30291413
vspre833cf:30267465
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
vscus158cf:30286554
pythonvsuse255:30303025
vscgsv2:30305091
vscorehov:30301224
vscod805:30301674

@vscodebot
Copy link

vscodebot bot commented May 25, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@isidorn isidorn added *duplicate Issue identified as a duplicate of another issue(s) file-explorer Explorer widget issues labels May 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) file-explorer Explorer widget issues
Projects
None yet
Development

No branches or pull requests

3 participants
@isidorn @andyhohorst-highgear and others