Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search in directory in multi root workspace totally broken #126883

Closed
linsui opened this issue Jun 22, 2021 · 7 comments
Closed

Search in directory in multi root workspace totally broken #126883

linsui opened this issue Jun 22, 2021 · 7 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster

Comments

@linsui
Copy link

linsui commented Jun 22, 2021

Issue Type: Bug

Creat a workspace.
Add directory a.
Add directory a/b.
Search in b.
See results in a.

VS Code version: VSCodium 1.57.0 (b4c1bd0, 2021-06-13T03:20:25.029Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: No

@roblourens
Copy link
Member

Please try with an official vscode build, not vscodium

@roblourens roblourens added the info-needed Issue requires more information from poster label Jun 22, 2021
@linsui
Copy link
Author

linsui commented Jun 23, 2021

I reproduce it in vscode. It seems the folder name is important.

This is the directory structure. In both a.txt is test.

test
    - testaaa
        - a.txt
    - a.txt

Add test and testaaa to workspace. Then search test in testaaa. I got results from two files.

@linsui
Copy link
Author

linsui commented Jun 23, 2021

sshot-002

@roblourens
Copy link
Member

Open files will be searched even if they don't match the "files to include" query #31819

@roblourens roblourens added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 23, 2021
@linsui
Copy link
Author

linsui commented Jun 24, 2021

No. It's not needed to reporoduce this bug.

@roblourens
Copy link
Member

Actually, there was another issue fixed recently that allowed 'include' to match a different workspace folder if it started with the same substring. You can try in Insiders or check after the next release - should be fixed

@linsui
Copy link
Author

linsui commented Jun 26, 2021

Sounds like it's that bug. Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants