Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks - Create new notebook not honoring default kernel #134830

Closed
claudiaregio opened this issue Oct 4, 2021 · 6 comments
Closed

Notebooks - Create new notebook not honoring default kernel #134830

claudiaregio opened this issue Oct 4, 2021 · 6 comments
Assignees
Labels
feature-request Request for new features or functionality notebook-kernel

Comments

@claudiaregio
Copy link

Environment data

  • VS Code version: 1.61.0 - insider
  • Jupyter Extension version (available under the Extensions sidebar): v2021.9.1001294413

Steps to reproduce:

  1. Create new notebook
  2. Select kernel is always available despite having the default kernel for jupyter notebooks selected
    image

Expected behavior

Notebook to be created with the default kernel selected

Actual behavior

Select kernel always available
image

*On a related note, is this a regression? Before core supported notion of default kernel, Jupyter extension used to automatically assign the kernel that was last used in a notebook.

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Oct 4, 2021

Before core supported notion of default kernel, Jupyter extension used to automatically assign the kernel that was last used in a notebook.

Not sure we did this.
The only concept of default kernel we had still applies and its the top of the list, when you get the kernel picker.

lect kernel is always available despite having the default kernel for jupyter notebooks selected

How do you select a default kernel.
This is how it has worked from day 1, in native notebooks, users will always get prompted to select a kernel for all notebooks.

@claudiaregio
Copy link
Author

I remember we had added functionality in the extension such that if a user opened a notebook it would assign the kernel to the one that was last used.

The gear in the kernel drop down now says "Set as default for jupyter notebooks", whereas previously it used to say "Set default kernel provider". Based on the changed tooltip I thought the functionality has changed but even if this was not the case I remember the Jupyter extension used to consistently create a new notebook with the previously used kernel.

@greazer greazer transferred this issue from microsoft/vscode-jupyter Oct 11, 2021
@greazer
Copy link
Member

greazer commented Oct 11, 2021

Automatically selecting a kernel on a new notebook is something that the jupyter extension can't do on it's own.

Related to #130946. We're also getting survey feedback asking for this.

@greazer greazer added the feature-request Request for new features or functionality label Oct 11, 2021
@rebornix rebornix removed their assignment Oct 21, 2021
@burkeholland
Copy link

Ran into this in the Golden Scenario. It seems odd to me to pick a different interpreter for Notebooks that are in the same "project" if you will. It also takes several seconds for VS Code to connect to the interpreter.

select-interpreter.mp4

@xkz0777
Copy link

xkz0777 commented Oct 21, 2023

Ran into this in the Golden Scenario. It seems odd to me to pick a different interpreter for Notebooks that are in the same "project" if you will. It also takes several seconds for VS Code to connect to the interpreter.

select-interpreter.mp4

I'm learning d2l now and I also feel very inconvenient about it. Want some configuration options in the workspace's settings.json to solve this problem.

@DonJayamanne
Copy link
Contributor

Given this is a very old issue and predates most of the kernel work done
I believe the underlying issue has been resolve since, or we can close this in favour of #130946

@DonJayamanne DonJayamanne self-assigned this Dec 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality notebook-kernel
Projects
None yet
Development

No branches or pull requests

8 participants