Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to Running Cell is great... but... could be improved to "Go to Last Run Cell". #142898

Closed
greazer opened this issue Feb 12, 2022 · 4 comments · Fixed by #154443
Closed

Go to Running Cell is great... but... could be improved to "Go to Last Run Cell". #142898

greazer opened this issue Feb 12, 2022 · 4 comments · Fixed by #154443
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders notebook-execution Issues related to running cells in a notebook on-release-notes Issue/pull request mentioned in release notes on-testplan
Milestone

Comments

@greazer
Copy link
Member

greazer commented Feb 12, 2022

  1. Open a notebook that has a good number of cells (20+) that will take a few minutes to run.
  2. Modify one of the cells in the middle (but won't take long to get to) to contain an error.
  3. Run All, making sure that the cell with the error isn't visible on the screen.

When execution ends due to the error it encounters, it's confusing what happened. Did the notebook complete? Why isn't it running? There's no indication that an error occurred that stopped execution.

Another approach here would be to automatically scroll to the cell that errors out, but I think that would be a pretty rude behavior.

This happened to me in a real-life situation, so marking as nb-golden.

@greazer greazer added feature-request Request for new features or functionality nb-golden notebook-execution Issues related to running cells in a notebook labels Feb 12, 2022
@rebornix rebornix assigned roblourens and unassigned rebornix Feb 16, 2022
@rebornix
Copy link
Member

This is a nice command to have but I'm not sure if I want to see all the time on the toolbar.

@roblourens roblourens added this to the Backlog milestone Feb 17, 2022
@greazer
Copy link
Member Author

greazer commented Apr 8, 2022

Referenced in microsoft/vscode-jupyter#9572.

@andreaschiappacasse
Copy link

+1

I would love to have this feature!
The use case mentioned by greazer is the main one, and it happens quite frequently to me and my colleagues.

Another use case would be something like:

  • Have a notebook with multiple cells
  • Run some computation-heavy cells which take some time to finish
  • Do some work somewhere else in the notebook
  • See from the status bar that the previously running cell finished
  • Quickly jump to the output by pressing "Go to Last Executed Cell" without scrolling

@smcateer
Copy link

Great feature req, I reckon.

The real issue here is "failing silently". Where one of the cells throws an error, the person running the code needs to be made aware of it - if it was up to me, you'd get a beep and jump to the error (so the traceback in the output is on the screen).

Not sure about:

  • What do you do when you are just running one (or a couple of) cells? Jumping in this scenario could get annoying.
  • What do you do if the cell is partially in view?
  • What do you do for warnings?

@andreamah andreamah self-assigned this Jul 7, 2022
@andreamah andreamah modified the milestones: Backlog, July 2022 Jul 13, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 15, 2022
@roblourens roblourens removed their assignment Jul 21, 2022
@andreamah andreamah added on-testplan on-release-notes Issue/pull request mentioned in release notes labels Jul 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders notebook-execution Issues related to running cells in a notebook on-release-notes Issue/pull request mentioned in release notes on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants
@roblourens @rebornix @andreaschiappacasse @smcateer @greazer @andreamah @VSCodeTriageBot and others