Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments API: allow specifying which comments are from current user #143005

Closed
hermannloose opened this issue Feb 14, 2022 · 3 comments
Closed

Comments API: allow specifying which comments are from current user #143005

hermannloose opened this issue Feb 14, 2022 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality

Comments

@hermannloose
Copy link
Contributor

This is for the Comments API, originally suggested in #142081 (comment).

The Comments API should allow extensions to indicate which comments are from the current user. VS Code could then style these comments differently in the comments panel and in the comments rendered in open editors, to provide more visual anchoring for users (in addition to usernames and avatars).

Additionally this would allow more built-in filtering in the comments panel, e.g. showing only the comment threads the current user is involved in, started, posted the latest comment on, etc.

This information could be

  • a field on CommentController, e.g. currentUser, to be compared by VS Code against CommentAuthorInformation.name.

    This minimizes necessary work by extensions, but probably works best if CommentAuthorInformation.name is something like a unique username.

  • a field on CommentAuthorInformation, e.g. isCurrentUser, to be populated by extensions for each Comment

    This is more work for extensions, but more flexible if an extension uses CommentAuthorInformation.name—documented as a display name—for full names and there might be two different John Smith's in the same set of comments.

@rebornix rebornix assigned alexr00 and unassigned rebornix Dec 2, 2022
@rebornix rebornix added the feature-request Request for new features or functionality label Dec 2, 2022
@VSCodeTriageBot VSCodeTriageBot added this to the Backlog Candidates milestone Dec 2, 2022
@VSCodeTriageBot
Copy link
Collaborator

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@VSCodeTriageBot
Copy link
Collaborator

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@VSCodeTriageBot
Copy link
Collaborator

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@VSCodeTriageBot VSCodeTriageBot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants