Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go To File cannot find dangling symlinks #144610

Closed
lzm0 opened this issue Mar 7, 2022 · 2 comments
Closed

Go To File cannot find dangling symlinks #144610

lzm0 opened this issue Mar 7, 2022 · 2 comments
Assignees
Labels
*out-of-scope Posted issue is not in scope of VS Code search Search widget and operation issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone

Comments

@lzm0
Copy link

lzm0 commented Mar 7, 2022

The Go To File/⌘P/Search files by name feature cannot find symbolic links that are broken/dangling.

Does this issue occur when all extensions are disabled?: Yes

Version: 1.65.0 (Universal)
Commit: b5205cc
Date: 2022-03-02T11:11:20.886Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 21.1.0

Steps to Reproduce:

  1. Clone this repository: https://github.com/lzm0/demo-for-vscode-issue-144610 which has the following structure
├── dangling-symlink
│   └── file -> ../fake/file
├── file
│   └── folder
│       └── note
├── live-symlink
│   └── file -> ../real/file
└── real
    └── file

5 directories, 4 files
  1. Search for file, and the dangling symlink is not in the results list.
    image
@lzm0 lzm0 changed the title Go To File cannot find dangling symlink Go To File cannot find dangling symlinks Mar 7, 2022
@lzm0
Copy link
Author

lzm0 commented Mar 7, 2022

This cause is ripgrep not supporting listing broken symbolic links without throwing an error message.

const ripgrep = spawnRipgrepCmd(this.config, folderQuery, this.config.includePattern, this.folderExcludePatterns.get(folderQuery.folder.fsPath)!.expression);

@roblourens roblourens added search Search widget and operation issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Mar 8, 2022
@roblourens roblourens added this to the Backlog milestone Mar 8, 2022
@roblourens roblourens added the *out-of-scope Posted issue is not in scope of VS Code label Dec 13, 2022
@vscodenpa
Copy link

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*out-of-scope Posted issue is not in scope of VS Code search Search widget and operation issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

3 participants