Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window controls are displayed over DevTools that are docked to the right side #150521

Closed
IllusionMH opened this issue May 27, 2022 · 2 comments · Fixed by #161027
Closed

Window controls are displayed over DevTools that are docked to the right side #150521

IllusionMH opened this issue May 27, 2022 · 2 comments · Fixed by #161027
Assignees
Labels
electron Issues and items related to Electron fixed-in-electron-19 Issues fixed with Electron 19.x update insiders-released Patch has been released in VS Code Insiders titlebar VS Code main title bar issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded windows VS Code on Windows issues

Comments

@IllusionMH
Copy link
Contributor

IllusionMH commented May 27, 2022

Issue Type: Bug

Looks like new WCO have static position and therefore overlap with DevTools controls in top right corner. And therefore block access to DevTools controls

Steps to reproduce:

  1. Be on Windows
  2. Open Developer Tools
  3. Dock DevTools to the right side

image

It would be ideally if it's possible to move those controls as before or at least force dev tools controls below windows controls if they are docked to the right and user is on Windows.

For those who want to move it (but cant't reach menu with dock options) use Ctrl+Shift+P and type "Dock" to see available dock commands.


Another minor thing: When VS Code starts - I can see same green controls in the corner while while other window is just dark gray (background color).

VS Code version: Code - Insiders 1.68.0-insider (6428d0f, 2022-05-27T05:15:53.993Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

System Info
Item Value
CPUs 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz (8 x 2995)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 31.50GB (12.72GB free)
Process Argv --crash-reporter-id 19aedffb-5c29-4248-9110-b5b20040c42f
Screen Reader no
VM 0%
Extensions: none
@IllusionMH
Copy link
Contributor Author

/assign sbatten -rebornix
as an author of #147947

@VSCodeTriageBot VSCodeTriageBot assigned sbatten and unassigned rebornix May 27, 2022
@sbatten
Copy link
Member

sbatten commented May 27, 2022

see electron/electron#34129

@sbatten sbatten added upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron windows VS Code on Windows issues titlebar VS Code main title bar issues and removed triage-needed labels May 27, 2022
@sbatten sbatten added this to the Backlog milestone May 27, 2022
@deepak1556 deepak1556 self-assigned this Sep 3, 2022
@deepak1556 deepak1556 added the fixed-in-electron-19 Issues fixed with Electron 19.x update label Sep 3, 2022
@deepak1556 deepak1556 modified the milestones: Backlog, September 2022 Sep 3, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 16, 2022
@sbatten sbatten added the verified Verification succeeded label Oct 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
electron Issues and items related to Electron fixed-in-electron-19 Issues fixed with Electron 19.x update insiders-released Patch has been released in VS Code Insiders titlebar VS Code main title bar issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants