Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone Repository explorer welcome view entry not localized in empty Remote-SSH window #151000

Open
joyceerhl opened this issue Jun 1, 2022 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug l10n-platform Localization platform issues (not wrong translations)
Milestone

Comments

@joyceerhl
Copy link
Contributor

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.68-insider
  • OS Version: Windows 11

Steps to Reproduce:

  1. Open an empty local window
  2. Install Chinese language pack and set display language to Chinese, restart
  3. Clone Repository entry in explorer is localized
  4. Now open an empty Remote-SSH window
  5. Install Chinese language pack on the remote too 🤷
  6. 🐛 Clone Repository entry in explorer is not localized
@TylerLeonhardt TylerLeonhardt added l10n-platform Localization platform issues (not wrong translations) bug Issue identified by VS Code Team member as probable bug labels Jun 1, 2022
@TylerLeonhardt TylerLeonhardt added this to the June 2022 milestone Jun 1, 2022
@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Jun 30, 2022

So I think this is because the language pack needs to be there when you start the server... which means you needed to reload again.

Language Packs should be automatically installed when we receive a locale that doesn't have a language pack already installed and then, if needed, the server should restart to ensure the strings are applied.

This is even more important in web where language packs aren't really even a thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug l10n-platform Localization platform issues (not wrong translations)
Projects
None yet
Development

No branches or pull requests

2 participants