Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support search/find within the terminal #15198

Closed
atombender opened this issue Nov 8, 2016 · 5 comments · Fixed by #28758
Closed

Support search/find within the terminal #15198

atombender opened this issue Nov 8, 2016 · 5 comments · Fixed by #28758
Assignees
@rebornix @Tyriar
Labels
feature-request Request for new features or functionality on-testplan terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
June 2017

Comments

@atombender
Copy link

  • VSCode Version: 1.7.1
  • OS Version: macOS 10.12.1

Panels (debug, terminal, etc.) have ability to search for text. I expected cmd-F to work.
@aeschli
Copy link
Contributor

aeschli commented Nov 8, 2016

Debug and terminal are different features. Can you file separate issues? I'll take this for the terminal

@aeschli aeschli changed the title Find command doesn't work in panel Find command doesn't work in terminal Nov 8, 2016
@atombender
Copy link
Author

Done (#15210).

@Tyriar Tyriar added feature-request Request for new features or functionality terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Nov 11, 2016
@Tyriar
Copy link
Member

Tyriar commented Nov 11, 2016

There would need to be hooks implemented upstream before this could be implemented within vscode.

@Tyriar Tyriar added this to the Backlog milestone Nov 11, 2016
This was referenced Jan 17, 2017
Closed
Closed
This was referenced Mar 24, 2017
Closed
Closed
@Tyriar Tyriar mentioned this issue Jun 2, 2017
Closed
@Tyriar Tyriar changed the title Find command doesn't work in terminal Support search/find within the terminal Jun 12, 2017
@Tyriar Tyriar mentioned this issue Jun 12, 2017
Closed
@Tyriar
Copy link
Member

Tyriar commented Jun 12, 2017

@rebornix any thoughts on if could make monaco and xterm.js share code for the find widget? It would be cool if the find in the terminal panel was consistent with other panels and the editor (see #28333).

@rebornix rebornix mentioned this issue Jun 15, 2017
Merged
@Tyriar Tyriar mentioned this issue Jun 15, 2017
Closed
7 tasks
@Tyriar
Copy link
Member

Tyriar commented Jun 15, 2017

@rebornix and I worked on adding some basic find functionality. There are a bunch of limitations with it now but it works and it's seems really slick.

image

Showing the find widget
Windows & Linux: ctrl+f (terminalFocus)
macOS: cmd+f (terminalFocus)

Check out #28768 for the limitations and future plans.

@Tyriar Tyriar mentioned this issue Jun 15, 2017
Closed
@kieferrm kieferrm mentioned this issue Jun 23, 2017
Closed
30 tasks
@Tyriar Tyriar modified the milestones: June 2017, Backlog Jun 26, 2017
@Tyriar Tyriar mentioned this issue Jun 26, 2017
Closed
3 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality on-testplan terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
June 2017
Development

Successfully merging a pull request may close this issue.

Find in terminal rebornix/vscode
5 participants
@atombender @roblourens @rebornix @Tyriar @aeschli