Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing localization for ES modules in monaco-editor-core #153256

Open
graphemecluster opened this issue Jun 26, 2022 · 2 comments
Open

Missing localization for ES modules in monaco-editor-core #153256

graphemecluster opened this issue Jun 26, 2022 · 2 comments
Assignees
Labels
ESM Issues caused by our AMD => ESM work feature-request Request for new features or functionality l10n-platform Localization platform issues (not wrong translations) monaco-editor
Milestone

Comments

@graphemecluster
Copy link

Search Terms: ES modules, NPM, build, gulp tasks

There are a couple of issues opened and closed in the monaco-editor repo (#1322, #1514, #2446) but I can't find one in this repo despite that the related source code is here, so I am opening one for traceability.

Non-official solutions like blutorange/primefaces-monaco/ESM-I18N.md and repos like wang12124468/monaco-editor-nls are not ideal because these solutions are regex-based and require additional steps.

Inspecting the tasks code in the build folder, I believe that the reason behind this is that the ESM files are only built by the tsc command while the AMD files are compiled with custom code in build/lib/tsb. More importantly the AMD files pass though the build/lib/nls.ts transformer but the ESM files do not, so I guess a simple line of nls.nls() does the job. I am new to this repo and am not sure what needs to be done additionally, or else I were opening a PR implementing this.

@dbaeumer
Copy link
Member

@TylerLeonhardt we worked on a story for the AMD build of the Monaco editor but for ESM no effort has been spent yet. I am actually not sure either what the effort would be to get this working.

@alexdima alexdima added feature-request Request for new features or functionality monaco-editor labels Jun 27, 2022
@alexdima alexdima added this to the Backlog milestone Jun 27, 2022
@TylerLeonhardt TylerLeonhardt added the l10n-platform Localization platform issues (not wrong translations) label Dec 6, 2022
@cary-hu
Copy link

cary-hu commented Jul 10, 2023

Any update?

@bpasero bpasero added the ESM Issues caused by our AMD => ESM work label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ESM Issues caused by our AMD => ESM work feature-request Request for new features or functionality l10n-platform Localization platform issues (not wrong translations) monaco-editor
Projects
None yet
Development

No branches or pull requests

7 participants