Missing localization for ES modules in monaco-editor-core
#153256
Labels
ESM
Issues caused by our AMD => ESM work
feature-request
Request for new features or functionality
l10n-platform
Localization platform issues (not wrong translations)
monaco-editor
Milestone
Search Terms: ES modules, NPM, build, gulp tasks
There are a couple of issues opened and closed in the monaco-editor repo (#1322, #1514, #2446) but I can't find one in this repo despite that the related source code is here, so I am opening one for traceability.
Non-official solutions like blutorange/primefaces-monaco/ESM-I18N.md and repos like wang12124468/monaco-editor-nls are not ideal because these solutions are regex-based and require additional steps.
Inspecting the tasks code in the
build
folder, I believe that the reason behind this is that the ESM files are only built by thetsc
command while the AMD files are compiled with custom code inbuild/lib/tsb
. More importantly the AMD files pass though thebuild/lib/nls.ts
transformer but the ESM files do not, so I guess a simple line ofnls.nls()
does the job. I am new to this repo and am not sure what needs to be done additionally, or else I were opening a PR implementing this.The text was updated successfully, but these errors were encountered: