Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer possible to reload a window without workspace #15400

Closed
bpasero opened this issue Nov 12, 2016 · 0 comments
Closed

No longer possible to reload a window without workspace #15400

bpasero opened this issue Nov 12, 2016 · 0 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded workbench-hot-exit Preservation of unsaved changes across restarts
Milestone
November 2016

Comments

@bpasero
Copy link
Member

bpasero commented Nov 12, 2016

Seems related to hot exit, when I reload inside an empty window I get:

shell.js:263 Cannot read property 'replace' of undefined: TypeError: Cannot read property 'replace' of undefined
    at Function.URI.file (/Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/uri.js:209:24)
    at VSCodeWindow.reload (/Users/bpasero/Development/Microsoft/monaco/out/vs/code/electron-main/window.js:319:116)
    at /Users/bpasero/Development/Microsoft/monaco/out/vs/code/electron-main/windows.js:163:25
    at Promise_ctor.CompletePromise_done [as done] (/Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.raw.js:1524:34)
    at Object.notifySuccess [as _notify] (/Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.raw.js:1180:48)
    at Object.enter (/Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.raw.js:852:30)
    at Promise_ctor._run (/Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.raw.js:1068:29)
    at Promise_ctor._completed (/Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.raw.js:1036:18)
    at EventEmitter.<anonymous> (/Users/bpasero/Development/Microsoft/monaco/out/vs/code/electron-main/lifecycle.js:125:21)
    at EventEmitter.g (events.js:286:16)
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-hot-exit Preservation of unsaved changes across restarts important Issue identified as high-priority labels Nov 12, 2016
@Tyriar Tyriar added this to the November 2016 milestone Nov 13, 2016
@Tyriar Tyriar closed this as completed in 3408691 Nov 14, 2016
@bpasero bpasero added the verified Verification succeeded label Dec 8, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded workbench-hot-exit Preservation of unsaved changes across restarts
Projects
None yet
Milestone
November 2016
Development

No branches or pull requests
2 participants
@bpasero @Tyriar