Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Language extensions should not be installable #154461

Closed
joaomoreno opened this issue Jul 8, 2022 · 4 comments · Fixed by #154925
Closed

Web: Language extensions should not be installable #154461

joaomoreno opened this issue Jul 8, 2022 · 4 comments · Fixed by #154925
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Milestone

Comments

@joaomoreno
Copy link
Member

On the web, we just make NLS work without installing language extensions. But they still appear installable when listed in the extensions view. One idea: show a Set Language button, instead of the Install button, or similar.

cc @TylerLeonhardt

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue extensions Issues concerning extensions labels Jul 8, 2022
@joaomoreno joaomoreno added this to the July 2022 milestone Jul 8, 2022
@joaomoreno joaomoreno added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Jul 8, 2022
@TylerLeonhardt
Copy link
Member

Personally I would prefer to hide them so we get closer to our long term vision of Language Pack Extensions as an implementation detail.

@TylerLeonhardt
Copy link
Member

Isn't this more in bug territory since today you get an "install on browser" button that, when clicked, actually does nothing whatsoever? That's confusing to the user.

@joaomoreno
Copy link
Member Author

My 2c: I wouldn't go and hide them. There still might be value in showing them, for reviews, links, etc. Also it wouldn't match the desktop experience until that one also aligns with the long term vision. It would be confusing to see them in one environment and not in the other.

If resolving the bug involves simply hiding them, then yes, it's a bug. Otherwise, if we're planning on having a button to Set Language, I argue this is a feature request.

@sandy081 sandy081 removed the polish Cleanup and polish issue label Jul 10, 2022
@sandy081
Copy link
Member

Added Set Display Language button instead of Install button for language pack extensions in web. Please take a look at the following video:

Kapture.2022-07-12.at.14.31.03.mp4

If the language is already set, then no action is shown. Please see the German Language Pack extension

image

@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 13, 2022
@sandy081 sandy081 added the verification-needed Verification of issue is requested label Jul 25, 2022
@sandy081 sandy081 added on-testplan and removed verification-needed Verification of issue is requested labels Jul 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants