-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build VSCode got stuck in node-gyp #160864
Comments
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.71.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding! |
I am create issue in other repo to help find out what's wrong, but still got no answer, hope someone can help me throught this.
|
I also build a minimal project to reproduce error, mainly using the @vscode/sqlite3, the error seems the same.https://github.com/ouliuquan/testsqlite3 |
It seems be related to this issue, about the no-ASCII support lack of node-gyp: But my path: |
In order to rule out the This is my newest log:
|
@deepak1556, could you take a look? Thank you! |
The native module has an intermediate step that tries to extract an archive using a python script, and the python executable is found in this way https://github.com/microsoft/vscode-node-sqlite3/blob/15e3606959a08cc5d78046cf9de533b3f53d5f63/deps/sqlite3.gyp#L65. Since we are not adding any quotes around the executable path, in your case There seems to be PR microsoft/vscode-node-sqlite3#24 to address this issue, you can apply that change locally to get past the error. @bpasero do we want to merge the above PR and make a new release or do we focus on dropping our fork microsoft/vscode-node-sqlite3#11 which would also resolve this issue. |
Yeah lets get the change into our fork and bump the version. Dropping our fork is a considerable effort that I currently have no time for. |
Since I changed my Python path to |
Closing as upstream. |
Does this issue occur when all extensions are disabled?: Yes
Steps to Reproduce:
1.
git clone --depth 1 --branch 1.71.1 https://github.com/microsoft/vscode.git
2.
yarn
#nodejs/node-gyp#2732
#TryGhost/node-sqlite3#1635
The text was updated successfully, but these errors were encountered: