Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsx] Mark occurrences on embeddded html: Select open and closing tag #1650

Closed
wilsonmarkj067 opened this issue Dec 25, 2015 · 5 comments
Closed

[jsx] Mark occurrences on embeddded html: Select open and closing tag #1650

wilsonmarkj067 opened this issue Dec 25, 2015 · 5 comments
Assignees
@egamma
Labels
feature-request Request for new features or functionality javascript JavaScript support issues
Milestone
Backlog

Comments

@wilsonmarkj067
Copy link

In large files, it is very difficult to identify the closing tag. When the cursor is present inside the opening tag, only closing tag should be highlighted.
@bpasero bpasero added the *question Issue represents a question, should be posted to StackOverflow (VS Code) label Dec 28, 2015
@bpasero bpasero added this to the Backlog milestone Dec 28, 2015
@aeschli
Copy link
Contributor

aeschli commented Jan 8, 2016

That's already what we do. The overview ruler shows helps you find the marked areas if the file is large.
image

Please reopen if I misunderstood.

@aeschli aeschli closed this as completed Jan 8, 2016
@wilsonmarkj067
Copy link
Author

Well, the problem is this.

screen shot 2016-01-11 at 12 07 49 am

This is a .jsx file. I hope you guys get the issue this time.

@wilsonmarkj067
Copy link
Author

I cannot reopen the issue. @aeschli

@aeschli aeschli reopened this Jan 11, 2016
@aeschli aeschli added feature-request Request for new features or functionality javascript JavaScript support issues and removed *question Issue represents a question, should be posted to StackOverflow (VS Code) labels Jan 11, 2016
@aeschli aeschli assigned egamma and unassigned aeschli Jan 11, 2016
@aeschli aeschli changed the title How to identify closing html tag? [jsx] Mark occurrences on embeddded htm: Select open and closing tag Jan 11, 2016
@aeschli aeschli changed the title [jsx] Mark occurrences on embeddded htm: Select open and closing tag [jsx] Mark occurrences on embeddded html: Select open and closing tag Jan 11, 2016
@egamma
Copy link
Member

egamma commented Jan 11, 2016

In JSX files mark occurrences is currently done just textually (and it is unrelated to what is done in .html files).

We will switch the underlying infrastructure to Salsa see microsoft/TypeScript#4789. Salsa will provide what is done in .tsx files in .jsx files. I've just checked the latest support in .tsx and this feature request isn't covered. I suggest to reproduce your problem in a .tsx file and then file a feature request against typescript https://github.com/Microsoft/typescript.

@egamma egamma closed this as completed Jan 11, 2016
@dlong500
Copy link

I'm not seeing anything in the typescript repo about this, and I'm finding it hard to find the right terminology to search for it. Has there been any movement on this feature in typescript that will fix this for vscode? It's a major pain when dealing with large JSX blocks to not be able to easily see matching opening/closing tags.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@egamma egamma

Labels
feature-request Request for new features or functionality javascript JavaScript support issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@egamma @dlong500 @bpasero @aeschli @wilsonmarkj067