Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot Exit: Very difficult to get out of a bad search/replace #16827

Closed
alexdima opened this issue Dec 7, 2016 · 2 comments
Closed

Hot Exit: Very difficult to get out of a bad search/replace #16827

alexdima opened this issue Dec 7, 2016 · 2 comments
Assignees

Comments

@alexdima
Copy link
Member

alexdima commented Dec 7, 2016

Testing #16544

  • create a file generator.js
var fs = require('fs');

for (var i = 0; i < 200; i++) {
	fs.writeFileSync('consumer_'+i+'.ts', `
import {x} from './provider';

console.log(x);
`)
}

fs.writeFileSync('provider.ts', `
export var x = 'Hello world';
`)
  • run node generator.js
  • open the folder where you have generated these files
  • do a search for x whole words, case sensitive, *.ts files only
  • replace everything with y
  • run the replace
  • close VS Code
  • open VS Code
  • the files are restored and slowly dots are appearing next to the file names. (why slowly?)
  • try to close all the files (via right click close all, or via the close all editors action in the explorer)

You get prompted for each and every one. This is a regression IMHO since in the stable version there is a single dialog that prompts me for all 200+ files:

image

@bpasero
Copy link
Member

bpasero commented Dec 7, 2016

This is a duplicate of #8009 which is now becoming more important with the advent of hot exit being on by default.

@Tyriar
Copy link
Member

Tyriar commented Dec 7, 2016

The slow dirty indicator is being discussed in #16584, let's close this off as a duplicate of that and #8009.

@Tyriar Tyriar closed this as completed Dec 7, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants