Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git - Untracked Folders #169253

Open
lszomoru opened this issue Dec 15, 2022 · 3 comments
Open

Git - Untracked Folders #169253

lszomoru opened this issue Dec 15, 2022 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality git GIT issues
Milestone

Comments

@lszomoru
Copy link
Member

In case of large monorepos there is significant performance difference between running git status -uall and git status. Depending on the value of the git.untrackedChanges setting, VS Code either uses git status -uall or git status -uno. Given the performance difference between those two commands want to explore a way to show untracked folders in the "Source Control" view, and have a setting that one can configure to automatically expand these folders or only expand them on demand.

//cc @digitarald

@lszomoru lszomoru added feature-request Request for new features or functionality git GIT issues labels Dec 15, 2022
@lszomoru lszomoru added this to the January 2023 milestone Dec 15, 2022
@lszomoru lszomoru self-assigned this Dec 15, 2022
@digitarald
Copy link
Contributor

Love that idea. Reducing it down to untracked folders would greatly simplify the untracked changes list and the actions users can do (stage, ignore, delete, etc).

@lszomoru
Copy link
Member Author

I have been thinking a bit more about this, and introducing the concept of a "folder" in the "Source Control" view would be a larger undertaking. While we can go down that path, there is another approach that would give us the performance improvements while keeping the current user experience of always rendering files in the "Source Control" view:

  1. Use git status on the git repository
  2. Update our status parser to have the ability to detect untracked folders
  3. In case of any untracked folders are detected call git status -uall folder1 folder2 folderN
  4. Parse the output of the command and "merge" the resources into the original git status call

//cc @joaomoreno, @digitarald

@lszomoru
Copy link
Member Author

We explored the idea of creating a new group called "Untracked Folders" but based on early feedback we have found that there are some very rough edges given the current vscode extension API. We have decided to table this effort for the time being while we better understand the changes that are needed to the vscode extension API to create a better user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality git GIT issues
Projects
None yet
Development

No branches or pull requests

2 participants