Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsconfig extends support jump to definition when using package #171365

Closed
tjx666 opened this issue Jan 15, 2023 · 10 comments
Closed

tsconfig extends support jump to definition when using package #171365

tjx666 opened this issue Jan 15, 2023 · 10 comments
Assignees
@mjbvz
Labels
info-needed Issue requires more information from poster typescript Typescript support issues

Comments

@tjx666
Copy link
Contributor

tjx666 commented Jan 15, 2023 •
edited
Loading

@mjbvz

image

2023-01-18.02.38.16.mov

Reproduce:

  1. git clone git@github.com:tjx666/vite-issue-reproduce.git
  2. git checkout vscode-tsconfig-issue
  3. pnpm install
  4. open apps/app/tsconfig.json
  5. try CMD + click to extends field
@mjbvz
Copy link
Collaborator

mjbvz commented Jan 17, 2023

Please share a minimal project which demonstrates this

@mjbvz mjbvz added the info-needed Issue requires more information from poster label Jan 17, 2023
@tjx666
Copy link
Contributor Author

tjx666 commented Jan 17, 2023 •
edited
Loading

@mjbvz just like

2023-02-09.10.32.22.mov

@mjbvz
Copy link
Collaborator

mjbvz commented Jan 17, 2023

Please share the code. This makes it much faster to investigate issues like this

tjx666 pushed a commit to tjx666/vite-issue-reproduce that referenced this issue Jan 17, 2023
https://github.com/microsoft/vscode/issues/171365
fc5d9ce
@tjx666
Copy link
Contributor Author

tjx666 commented Jan 17, 2023

@mjbvz updated reproduce in issue description

@mjbvz mjbvz added typescript Typescript support issues and removed info-needed Issue requires more information from poster labels Feb 9, 2023
@mjbvz
Copy link
Collaborator

mjbvz commented Feb 9, 2023

Where's @scripts coming from? I don't see it in that project

Please put together a minimal, self contained example of the issue

@mjbvz mjbvz added the info-needed Issue requires more information from poster label Feb 9, 2023
@tjx666
Copy link
Contributor Author

tjx666 commented Feb 9, 2023 •
edited
Loading

The @scripts/tsconfig is a workspace package, you can the repro for details: https://github.com/tjx666/vite-issue-reproduce/tree/vscode-tsconfig-issue

I forget to tell you to checkout branch vscode-tsconfig-issue

image

@tjx666
Copy link
Contributor Author

tjx666 commented Feb 21, 2023

@mjbvz

A more simple way to reproduce:

  1. open a node project contains tsconfig
  2. npm install @vue/tsconfig
  3. extends in tsconfig.json by "extends": "@vue/tsconfig/tsconfig.web.json",

image

@tjx666
Copy link
Contributor Author

tjx666 commented Feb 24, 2023

@mjbvz still have question about this issue?

@mjbvz
Copy link
Collaborator

mjbvz commented Feb 27, 2023

Hm that latest example using "extends": "@vue/tsconfig/tsconfig.web.json" works fine for me on MacOS

@tjx666
Copy link
Contributor Author

tjx666 commented Feb 28, 2023

I find this is a issue of volar.

@tjx666 tjx666 closed this as completed Feb 28, 2023
@tjx666 tjx666 mentioned this issue Feb 28, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
info-needed Issue requires more information from poster typescript Typescript support issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjbvz @tjx666