Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot-Exit: works only if there is one instance (window) of VS Code open #17548

Closed
bogdan-d opened this issue Dec 19, 2016 · 3 comments
Closed
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) workbench-hot-exit Preservation of unsaved changes across restarts

Comments

@bogdan-d
Copy link

bogdan-d commented Dec 19, 2016

  • VSCode Version: 1.9.0-insider (also reproducible in 1.8.0)
  • OS Version: Windows 10

Steps to Reproduce:

  1. Open VS Code anywhere, create new file, write something but don't save
  2. Open another VS Code window ( Ctrl+Shift+N ), create new file, write something but don't save
  3. Close either window

The expected behavior would be for the hot-exit feature to kick in and not to display the file-save prompt.
I'm not sure if this is a bug or a missing feature.

Well, probably a more common and practical use case would be to open two folders into separate VS Code windows.

@egamma egamma added the workbench-hot-exit Preservation of unsaved changes across restarts label Dec 19, 2016
@bpasero
Copy link
Member

bpasero commented Dec 19, 2016

This works "as-designed" and was an explicit decision. The rationale is that you cannot close a window unless the application quits in the same way you cannot close a dirty editor when you click the close button. In other words, we prevent you from "hiding" dirty things by explicitly asking to save or discard so that upon next restart there is not things being restored that have been closed before.

@bogdan-d
Copy link
Author

I see what you mean, but for me, the hot-exit feature is almost useless, because, since VS Code doesn't allow opening two or more project folders in the same window, I am kind of forced to work with multiple windows open at the same time. This is why I felt the need to report this, I though perhaps I wasn't alone :)

@Tyriar
Copy link
Member

Tyriar commented Dec 19, 2016

#15467 is exploring our options for this, one of my goals for January is to have a solid way forward on less strict hot exit/customization so expect movement on this in 1.10.

@Tyriar Tyriar closed this as completed Dec 19, 2016
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 19, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) workbench-hot-exit Preservation of unsaved changes across restarts
Projects
None yet
Development

No branches or pull requests

4 participants