Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore prompting to enable Cloud Changes on web #179014

Closed
joyceerhl opened this issue Apr 3, 2023 · 4 comments
Closed

Explore prompting to enable Cloud Changes on web #179014

joyceerhl opened this issue Apr 3, 2023 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@joyceerhl
Copy link
Collaborator

joyceerhl commented Apr 3, 2023

Verification

  1. Ensure that you have a clean setup. We only show this for a new user who has never used insiders.vscode.dev before.
  2. Open a GitHub URL such as https://insiders.vscode.dev/github/microsoft/vscode
  3. Edit any file in the repo.
  4. An overlay widget, such as the one shown below, should appear in the top right-hand corner of the editor when you have paused typing. The overlay widget should call out that you can access your changes across devices using Cloud Changes

Please verify that this dialog only appears once during your first session and that it does not interrupt your typing.

@joyceerhl joyceerhl added the feature-request Request for new features or functionality label Apr 3, 2023
@joyceerhl joyceerhl added this to the April 2023 milestone Apr 3, 2023
@joyceerhl joyceerhl self-assigned this Apr 3, 2023
@joyceerhl joyceerhl modified the milestones: April 2023, May 2023 Apr 21, 2023
@joyceerhl joyceerhl modified the milestones: May 2023, June 2023 May 26, 2023
@joyceerhl joyceerhl added on-testplan verification-needed Verification of issue is requested and removed on-testplan labels Jun 26, 2023
@andreamah andreamah added the verified Verification succeeded label Jun 27, 2023
@andreamah
Copy link
Contributor

Should there be a picture of an overlay widget in the above comment? I think the comment mentions it but I can't see one.

Also, I tried this just now in an incognito window (after logging into github) and I didn't see an overlay widget? I had to use a non-msft repo because I can't authenticate the msft org from incognito.

@andreamah andreamah removed the verified Verification succeeded label Jun 27, 2023
@joyceerhl
Copy link
Collaborator Author

@bhavyaus is there an experimental setting that folks need to set to see the overlay widget still?

@joaomoreno
Copy link
Member

I also can't seem to get this dialog to open up. I tried enabling workbench.welcome.experimental.dialog, but that didn't seem to make a difference.

@joaomoreno joaomoreno added the verification-steps-needed Steps to verify are needed for verification label Jun 28, 2023
@bhavyaus
Copy link
Collaborator

bhavyaus commented Jun 28, 2023

Verification Steps:
2. Ensure that you have a clean setup. We only show this for a new user who has never used insider.vscode.dev before.
3. Open a GitHub URL such as https://insiders.vscode.dev/github/microsoft/vscode
4. Edit any file in the repo.
5. An overlay widget, such as the one shown below, should appear in the top right-hand corner of the editor when you have paused typing.

image

@rzhao271 rzhao271 added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Jun 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants