Breakpoints which appear in margin and injected text aren't factored into glyph margin width

[joyceerhl]

1. Have an active debug session
2. Add a bookmark to one line
3. Add a breakpoint to the same line where the breakpoint ends up being an inline breakpoint
4. 🐛 the margin resizes so that the bookmark on the line in step 2 is also gone

Debugging this in devtools, this appears to be because the breakpoint does not appear in the result of getAllMarginDecorations. Therefore it's not taken into account when calculating the size of the margin.

vscode/src/vs/editor/common/viewModel/viewModelImpl.ts

Line 465 in ab7c32a

const decorations = this.model.getAllMarginDecorations();

When we actually go to render the decorations, we use a different source of information ctx.getDecorationsInViewport, where the breakpoint does show up, so we end up rendering it even though no lane space was allocated for it.

vscode/src/vs/editor/browser/viewParts/glyphMargin/glyphMargin.ts

Line 188 in ab7c32a

const decorations = ctx.getDecorationsInViewport();

Those inline breakpoints appear by using injected text:

vscode/src/vs/workbench/contrib/debug/browser/breakpointEditorContribution.ts

Lines 141 to 145 in ab7c32a

	before: renderInline ? {
	content: noBreakWhitespace,
	inlineClassName: `debug-breakpoint-placeholder`,
	inlineClassNameAffectsLetterSpacing: true
	} : undefined,

I think the problem is that the fast path for getting just margin decorations doesn't search the injected text interval tree for margin decorations (because I didn't realize that margin decorations could appear in the injected text interval tree when implementing #179974).

vscode/src/vs/editor/common/model/textModel.ts

Lines 2063 to 2076 in ab7c32a

	private _search(filterOwnerId: number, filterOutValidation: boolean, overviewRulerOnly: boolean, cachedVersionId: number, onlyMarginDecorations: boolean): IntervalNode[] {
	if (overviewRulerOnly) {
	return this._decorationsTree1.search(filterOwnerId, filterOutValidation, cachedVersionId, onlyMarginDecorations);
	} else if (onlyMarginDecorations) {
	const r0 = this._decorationsTree0.search(filterOwnerId, filterOutValidation, cachedVersionId, onlyMarginDecorations);
	const r1 = this._decorationsTree1.search(filterOwnerId, filterOutValidation, cachedVersionId, onlyMarginDecorations);
	return r0.concat(r1);
	} else {
	const r0 = this._decorationsTree0.search(filterOwnerId, filterOutValidation, cachedVersionId, onlyMarginDecorations);
	const r1 = this._decorationsTree1.search(filterOwnerId, filterOutValidation, cachedVersionId, onlyMarginDecorations);
	const r2 = this._injectedTextDecorationsTree.search(filterOwnerId, filterOutValidation, cachedVersionId, onlyMarginDecorations);
	return r0.concat(r1).concat(r2);
	}
	}

Only caught this now because inline breakpoints only show up when there are active debug sessions, and I didn't have a case where I set a breakpoint on a line with another decoration in a debug session till today :/